remove oc cluster up dependency on oc binary #15462
Conversation
|
this is un-verifiable until #15381 is resolved. |
|
@csrwng ptal |
can't it be verified with the released version of the images? |
technically perhaps, but i'd feel better seeing it work end to end w/ the latest origin images. |
| if err != nil { | ||
| return errors.NewError(fmt.Sprintf("failed generating client certificate, command output: %s\nerror: %v", out, err)) | ||
| return errors.NewError("cannot create client config").WithCause(err) |
There was a problem hiding this comment.
Add the command output as detail to the error:
errors.NewError("cannot create client config").WithCause(err).WithDetail(cmdOutput)
| "--user", "aggregator-front-proxy", | ||
| "--client-dir", configDir, | ||
| ).CombinedOutput() | ||
| return errors.NewError("cannot create signer cert").WithCause(err) |
There was a problem hiding this comment.
Same as below, add the output to the error details
There was a problem hiding this comment.
"do as i say, not as i did", eh? https://github.com/openshift/origin/blob/master/pkg/bootstrap/docker/openshift/admin.go#L136-L157
There was a problem hiding this comment.
It's called thought evolution :)
| User: "aggregator-front-proxy", | ||
| Output: cmdOutput, | ||
| } | ||
| createClientOptions.CreateClientFolder() |
There was a problem hiding this comment.
looks like you missed assigning the err variable
|
@csrwng updated. does seem to work with 3.6.0 |
|
/lgtm |
openshift-merge-robot
added
the
size/M
|
/approve no-issue |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, csrwng Associated issue requirement bypassed by: bparees The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-merge-robot
added
the
approved
bparees
removed
approved
openshift-merge-robot
added
the
approved
|
/test check |
|
/retest |
|
@smarterclayton @stevekuznetsov so at the time the bot posted this "failure" message (midnight) the test job in question was still running.... |
|
I guess it's in tear-down mode. |
|
/retest |
|
@bparees yeah we publish failure result as the first post-run step, whereas the rest of cleanup happens after |
|
Also technically the Jenkins job is in the failed state as soon as any build steps fail, and cannot leave the failed state as a result of post-build execution. With Rosie we always updated GitHub right before the job finished, but that's not the case anymore. |
|
Automatic merge from submit-queue (batch tested with PRs 15037, 15462) |
|
@LalatenduMohanty was not planning on it, but yes I can backport it for you. |
|
backport is here: #15471 |
|
@bparees Awesome thanks. |
No description provided.