start pkg/oc #15473
Merged
start pkg/oc #15473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-merge-robot
added
the
size/L
|
bootstrap move lgtm. |
|
/lgtm |
|
/approve no-issue |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, liggitt Associated issue requirement bypassed by: liggitt The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-merge-robot
added
the
approved
juanvallejo
approved these changes
Jul 26, 2017
openshift-merge-robot
removed
the
lgtm
|
/retest |
|
/test integration |
|
/retest |
|
TestTriggers_configChange: https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_integration/4908 /retest |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
1 similar comment
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a bulk move of low fanout packages to
pkg/ocso that we can start snipping unnecessary links, clean-up owner/approver files, and start working our way towards a separateoc.This has the biggest impact on @fabianofranz and @juanvallejo, but I think it is a net-win for them.
@bparees @csrwng I moved
pkg/bootstrapunderpkg/ocwhere it gets included, but I kept and tidied the existing owners file. You won't get bombarded with reviews for general CLI changes.@smarterclayton we've talked about this direction. I see this as a first step towards separating
ocwith minimal disruption so far.