tolerate cross-platform building of crio/cgroup build logic

[bparees]

No description provided.

[bparees]

@stevekuznetsov @smarterclayton ptal

[bparees]

/unassign @gabemontero @mfojtik
/assign @stevekuznetsov @smarterclayton

[bparees]

/retest

[stevekuznetsov]

Cross looks to be failing in a similar way

[stevekuznetsov]

@bparees got lucky this time:

hack/build-cross.sh
++ Building go targets for linux/amd64: images/pod cmd/dockerregistry cmd/gitserver vendor/k8s.io/kubernetes/cmd/hyperkube pkg/network/sdn-cni-plugin vendor/github.com/containernetworking/cni/plugins/ipam/host-local vendor/github.com/containernetworking/cni/plugins/main/loopback examples/hello-openshift
++ Building go targets for linux/amd64: cmd/openshift cmd/oc cmd/kubefed cmd/template-service-broker
++ Building go targets for darwin/amd64: cmd/openshift cmd/oc cmd/kubefed cmd/template-service-broker
vendor/github.com/google/cadvisor/container/common/inotify_watcher.go:20:2: no buildable Go source files in /go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/golang.org/x/exp/inotify
[ERROR] PID 11044: hack/lib/build/binaries.sh:228: `GOOS=${platform%/*} GOARCH=${platform##*/} go install -pkgdir "${OS_OUTPUT_PKGDIR}/${platform}" -tags "${OS_GOFLAGS_TAGS-} ${!platform_gotags_envvar:-}" -ldflags="${local_ldflags}" "${goflags[@]:+${goflags[@]}}" "${nonstatics[@]}"` exited with status 1.
[INFO] 		Stack Trace: 
[INFO] 		  1: hack/lib/build/binaries.sh:228: `GOOS=${platform%/*} GOARCH=${platform##*/} go install -pkgdir "${OS_OUTPUT_PKGDIR}/${platform}" -tags "${OS_GOFLAGS_TAGS-} ${!platform_gotags_envvar:-}" -ldflags="${local_ldflags}" "${goflags[@]:+${goflags[@]}}" "${nonstatics[@]}"`
[INFO] 		  2: hack/lib/build/binaries.sh:158: os::build::internal::build_binaries
[INFO] 		  3: hack/build-cross.sh:79: os::build::build_binaries
[INFO]   Exiting with code 1.
[ERROR] PID 6: hack/lib/build/binaries.sh:152: `local -a binaries=("$@")` exited with status 1.

[bparees]

vendor/github.com/google/cadvisor/container/common/inotify_watcher.go:20:2: no buildable Go source files in /go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/golang.org/x/exp/inotify
[ERROR] PID 11044: hack/lib/build/binaries.sh:228: `GOOS=${platform%/*} GOARCH=${platform##*/} go install -pkgdir "${OS_OUTPUT_PKGDIR}/${platform}" -tags "${OS_GOFLAGS_TAGS-} ${!platform_gotags_envvar:-}" -ldflags="${local_ldflags}" "${goflags[@]:+${goflags[@]}}" "${nonstatics[@]}"` exited with status 1.

hm. not even something my previous or new PRs touched.

[bparees]

/retest

[bparees]

hack/build-cross.sh succeeds for me locally.

[stevekuznetsov]

cross is happy

thanks @bparees

/lgtm
/approve

[openshift-merge-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevekuznetsov

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• pkg/build/OWNERS [stevekuznetsov]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[bparees]

/retest

[bparees]

/retest

[bparees]

/retest Ben Parees | OpenShift

…

On Sep 29, 2017 4:59 AM, "OpenShift CI Robot" ***@***.***> wrote: @bparees <https://github.com/bparees>: The following test *failed*, say /retest to rerun them all: Test name Commit Details Rerun command ci/openshift-jenkins/extended_conformance_gce 1c1f653 <1c1f653> link <https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/16599/test_pull_request_origin_extended_conformance_gce/8896/> /test extended_conformance_gce Full PR test history <https://openshift-gce-devel.appspot.com/pr/16599>. Your PR dashboard <https://openshift-gce-devel.appspot.com/pr/bparees>. Please help us cut down on flakes by linking to <https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests> an open issue <https://github.com/openshift/origin/issues?q=is:issue+is:open> when you hit one in your PR. Instructions for interacting with me using PR comments are available here <https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md>. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra <https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:> repository. I understand the commands that are listed here <https://github.com/kubernetes/test-infra/blob/master/commands.md>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#16599 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEvl3uKRMoWQXu6kPjO_r7JR26cDH01Bks5snLGBgaJpZM4Pncue> .

[openshift-merge-robot]

Automatic merge from submit-queue.

[shantharama]

build is still failing for me on Mac here is the error

hack/build-cross.sh
[INFO] Detected go version: go version go1.10 darwin/amd64.
[WARNING] Detected golang version doesn't match required Go version.
[WARNING] This version mismatch could lead to differences in execution between this run and the CI systems.
[INFO] Detected go version: go version go1.10 darwin/amd64.
[WARNING] Detected golang version doesn't match required Go version.
[WARNING] This version mismatch could lead to differences in execution between this run and the CI systems.
[INFO] Detected go version: go version go1.10 darwin/amd64.
[WARNING] Detected golang version doesn't match required Go version.
[WARNING] This version mismatch could lead to differences in execution between this run and the CI systems.
++ Building go targets for linux/amd64: cmd/openshift cmd/oc cmd/oadm cmd/template-service-broker vendor/k8s.io/kubernetes/cmd/hyperkube

github.com/openshift/origin/pkg/oc/util/tokencmd

pkg/oc/util/tokencmd/negotiator_gssapi.go:25:7: undefined: gssapi.Lib
pkg/oc/util/tokencmd/negotiator_gssapi.go:32:8: undefined: gssapi.Name
pkg/oc/util/tokencmd/negotiator_gssapi.go:34:7: undefined: gssapi.CtxId
pkg/oc/util/tokencmd/negotiator_gssapi.go:43:8: undefined: gssapi.CredId
[ERROR] PID 47025: hack/lib/build/binaries.sh:210: GOOS=${platform%/*} GOARCH=${platform##*/} go install -pkgdir "${pkgdir}/${platform}" -tags "${OS_GOFLAGS_TAGS-} ${!platform_gotags_envvar:-}" -ldflags="${local_ldflags}" "${goflags[@]:+${goflags[@]}}" -gcflags "${gogcflags}" "${nonstatics[@]}" exited with status 2.
[INFO] Stack Trace:
[INFO] 1: hack/lib/build/binaries.sh:210: GOOS=${platform%/*} GOARCH=${platform##*/} go install -pkgdir "${pkgdir}/${platform}" -tags "${OS_GOFLAGS_TAGS-} ${!platform_gotags_envvar:-}" -ldflags="${local_ldflags}" "${goflags[@]:+${goflags[@]}}" -gcflags "${gogcflags}" "${nonstatics[@]}"
[INFO] 2: hack/lib/build/binaries.sh:156: os::build::internal::build_binaries
[INFO] 3: hack/build-cross.sh:76: os::build::build_binaries
[INFO] Exiting with code 2.