Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-enable openapi aggregation #17899

Merged
merged 2 commits into from
Jan 8, 2018
Merged

re-enable openapi aggregation #17899

merged 2 commits into from
Jan 8, 2018

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Dec 20, 2017

I haven't looked at performance characteristics.

/assign juanvallejo

@juanvallejo this may help somewhat

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 20, 2017
@juanvallejo
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2017
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, juanvallejo

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@deads2k deads2k force-pushed the server-56-turn-openapi-aggregation-back-on branch from cca5743 to ecdf81b Compare December 21, 2017 14:55
@deads2k deads2k added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Dec 21, 2017
@deads2k
Copy link
Contributor Author

deads2k commented Dec 21, 2017

/retest

6 similar comments
@deads2k
Copy link
Contributor Author

deads2k commented Dec 22, 2017

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Dec 22, 2017

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Dec 23, 2017

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Dec 23, 2017

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Dec 23, 2017

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Dec 23, 2017

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@deads2k
Copy link
Contributor Author

deads2k commented Dec 25, 2017

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@deads2k
Copy link
Contributor Author

deads2k commented Dec 31, 2017

/retest

4 similar comments
@deads2k
Copy link
Contributor Author

deads2k commented Dec 31, 2017

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Jan 1, 2018

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Jan 1, 2018

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Jan 1, 2018

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Jan 2, 2018

/retest

3 similar comments
@deads2k
Copy link
Contributor Author

deads2k commented Jan 2, 2018

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Jan 2, 2018

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Jan 3, 2018

/retest

@deads2k deads2k force-pushed the server-56-turn-openapi-aggregation-back-on branch from ecdf81b to 9b41699 Compare January 3, 2018 13:56
@openshift-merge-robot openshift-merge-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2018
@deads2k deads2k added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2018
@deads2k
Copy link
Contributor Author

deads2k commented Jan 3, 2018

/retest

2 similar comments
@deads2k
Copy link
Contributor Author

deads2k commented Jan 3, 2018

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Jan 3, 2018

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@deads2k
Copy link
Contributor Author

deads2k commented Jan 5, 2018

/test all

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 17899, 17726, 17989).

@openshift-merge-robot openshift-merge-robot merged commit bb8268e into openshift:master Jan 8, 2018
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 8, 2018 •
edited
Loading

@deads2k: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_gce 9b41699 link /test extended_conformance_gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k deads2k deleted the server-56-turn-openapi-aggregation-back-on branch January 24, 2018 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt Awaiting requested review from liggitt

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@juanvallejo juanvallejo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@deads2k @juanvallejo @openshift-ci-robot @openshift-bot @openshift-merge-robot