Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add virtual resource for SAR checks #18968

Merged
merged 1 commit into from
Mar 22, 2018
Merged

Add virtual resource for SAR checks #18968

merged 1 commit into from
Mar 22, 2018

Conversation

legionus
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 13, 2018
@legionus
Add virtual resource for SAR checks
1762f0b 
Signed-off-by: Gladkov Alexey <agladkov@redhat.com>
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 13, 2018
@legionus
Copy link
Contributor Author

/retest

3 similar comments
@legionus
Copy link
Contributor Author

/retest

@legionus
Copy link
Contributor Author

/retest

@legionus
Copy link
Contributor Author

/retest

@legionus legionus requested a review from bparees March 16, 2018 14:40
@bparees
Copy link
Contributor

bparees commented Mar 16, 2018

/approve
@openshift/api-review any concerns? the decision to add this role was made here:
openshift/image-registry#73 (comment)

@bparees bparees self-assigned this Mar 16, 2018
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2018
@deads2k
Copy link
Contributor

deads2k commented Mar 16, 2018

@openshift/api-review any concerns? the decision to add this role was made here:
openshift/image-registry#73 (comment)

As a general statement, the prometheus scraper clusterrole looks like a very good candidate for clusterrole aggregation. The new permission looks fine.

@legionus
Copy link
Contributor Author

/retest

@legionus legionus mentioned this pull request Mar 16, 2018
Merged
@bparees
Copy link
Contributor

bparees commented Mar 16, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, legionus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@legionus
Copy link
Contributor Author

/retest

3 similar comments
@legionus
Copy link
Contributor Author

/retest

@legionus
Copy link
Contributor Author

/retest

@bparees
Copy link
Contributor

bparees commented Mar 20, 2018

/retest

@bparees
Copy link
Contributor

bparees commented Mar 21, 2018

closing and reopening to try to kick prow, something is stuck.

@bparees bparees closed this Mar 21, 2018
@bparees bparees reopened this Mar 21, 2018
@bparees
Copy link
Contributor

bparees commented Mar 21, 2018

/retest all

@bparees
Copy link
Contributor

bparees commented Mar 21, 2018 •
edited
Loading

@stevekuznetsov this seems stuck, tracer didn't give me any insight, but for example the unit test job actually completed days ago. prow still thinks it is "running" and i can't make it rerun it.

@bparees
Copy link
Contributor

bparees commented Mar 21, 2018 

{"component":"jenkins-operator","event-GUID":"dd52a8f0-2d47-11e8-802d-4d571a6aaeab","from":"pending","job":"test_pull_request_origin_unit","level":"info","msg":"Transitioning states.","name":"e47f56f3-2d47-11e8-87a9-0a58ac1011ec","org":"openshift","pr":18968,"repo":"origin","time":"2018-03-21T21:21:55Z","to":"success","type":"presubmit"},

@stevekuznetsov
Copy link
Contributor

/refresh

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 18905, 18968, 19016, 19037, 19056).

@openshift-merge-robot openshift-merge-robot merged commit d41e24d into openshift:master Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@bparees bparees Awaiting requested review from bparees

Assignees

@bparees bparees

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@legionus @bparees @deads2k @openshift-ci-robot @stevekuznetsov @openshift-merge-robot