router - depricate -expose-metrics --metrics-image #19432
Conversation
openshift-ci-robot
added
the
size/XS
|
@knobunc @smarterclayton PTAL |
bug 1499026 https://bugzilla.redhat.com/show_bug.cgi?id=1499026 1499026 - Deprecate oc adm router --expose-metrics and --metrics-image origin issue: 15982 openshift#15982 OCP 3.11 Signed-off-by: Phil Cameron <pcameron@redhat.com>
openshift-ci-robot
added
size/S
|
@smarterclayton What is the deprecation policy around this? Can we just remove it? Or do we have to have a note in the docs and the command line flags for N releases and then we can remove the functionality after N + M releases? |
|
@knobunc @smarterclayton I think we added the deprecation note in 3.7. |
|
We generally preserve the flags for a long time because the best outcome is
we break someone who has them in a script somewhere.
On Apr 19, 2018, at 11:15 AM, Phil Cameron <notifications@github.com> wrote:
@knobunc <https://github.com/knobunc> @smarterclayton
<https://github.com/smarterclayton> I think we added the deprecation note
in 3.7.
Somebody else removed the code except for the command line options. The
options before this PR were ignored, this PR removes them. Don't know when
that happened.
docs pr 8803 removes the note.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19432 (comment)>,
or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p04loReRhDkSLtnNvmjSl7VI8Dbjks5tqKn5gaJpZM4TbxJi>
.
|
|
@smarterclayton how long is "a long time"? A couple origin releases? |
|
3-4 releases |
|
/retest |
|
@knobunc PTAL |
|
So... we can remove it in 3.11 if we deprecated in 3.7? (That would be 4 releases including 3.7) |
|
@smarterclayton so is this ready to merge? Do we need to wait longer? |
|
/lgtm |
|
@smarterclayton @sdodson @knobunc extended_conformance_install tests expose-metrics and metrics-image. I have made changes in openshift-ansible PR 8177 to remove the tests. |
|
/retest |
|
/approve |
|
/retest |
|
/assign @smarterclayton |
|
@knobunc looks like this is all set except another approval. |
|
@juanvallejo bump for contrib approval |
|
/lgtm |
|
@knobunc @juanvallejo @sdodson @smarterclayton This has been hanging around for quite a while. Is there something we need to do to get this merged? |
|
/approve |
sdodson
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: knobunc, pecameron, sdodson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
It needed to be approved by someone in contrib/completions/OWNERS but I'm taking juan's lgtm as implicit approved and i've added the label to the pr |
|
/retest |
|
@sdodson @knobunc It seems to be a timeout: |
|
/test extended_conformance_install |
|
@pecameron: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
bug 1499026
https://bugzilla.redhat.com/show_bug.cgi?id=1499026
1499026 - Deprecate oc adm router --expose-metrics and --metrics-image
OCP 3.11
Signed-off-by: Phil Cameron pcameron@redhat.com