Remove --extended-test-output-dir and use --report-dir in e2e #19725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should be consistent with the upstream. The CLI helper should only be using framework.TestContext.OutputDir for its content. This fixes a bug when running ginkgo against the extended.test binary where gingko sets the working directory to a read-only directory (where the extended.test binary is located) but without output-dir set to anything the CLI helper defaults to creating the temporary file in the read only directory.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
|
/retest |
|
Merging to get e2es in container |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should be consistent with the upstream. The CLI helper should only be
using framework.TestContext.OutputDir for its content. This fixes a bug
when running ginkgo against the extended.test binary where gingko sets
the working directory to a read-only directory (where the extended.test
binary is located) but without output-dir set to anything the CLI helper
defaults to creating the temporary file in the read only directory.
Blocking running e2e inside an image (the binary is in a directory we don't have access to). With this change the output defaults to
/tmplike upstream e2e.