Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change logo, favicon, name on login page #20527

Merged
merged 1 commit into from
Aug 2, 2018
Merged

Change logo, favicon, name on login page #20527

merged 1 commit into from
Aug 2, 2018

Conversation

rhamilto
Copy link
Member

@rhamilto rhamilto commented Aug 2, 2018

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 2, 2018
@spadgett
Copy link
Member

spadgett commented Aug 2, 2018

Thanks @rhamilto

cc @enj @smarterclayton

@smarterclayton
Copy link
Contributor

Needs to be in release-3.10 as well, will you be cherry-pick after?

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 2, 2018
@enj
Copy link
Contributor

enj commented Aug 2, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enj, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2018
@openshift-merge-robot openshift-merge-robot merged commit cc44853 into openshift:master Aug 2, 2018
@rhamilto rhamilto deleted the branding branch August 2, 2018 23:13
@spadgett
Copy link
Member

spadgett commented Aug 2, 2018

3.10 change: #20528

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. queue/critical-fix retest-not-required size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants