Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Automation Broker Tag to the same as Openshift #20626

Closed
wants to merge 1 commit into from
Closed

Set Automation Broker Tag to the same as Openshift #20626

wants to merge 1 commit into from

Conversation

jmontleon
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 13, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jmontleon
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: pweil-

If they are not already assigned, you can assign the PR to them by writing /assign @pweil- in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cmoulliard
Copy link

The current namespace's name created by the ansible role is openshift-ansible-service-broker and not openshift-automation-service-broker

@jmontleon jmontleon requested a review from djzager August 16, 2018 15:02
@djzager
Copy link
Member

djzager commented Aug 16, 2018

The current namespace's name created by the ansible role is openshift-ansible-service-broker and not openshift-automation-service-broker

I believe you may be referring to openshift-ansible and the ansible-service-broker role. The ansible-role being referenced here comes from the ansible-service-broker/apb.

The automation-broker-apb role, by default, uses automation-broker for both the name of the broker and the namespace. In this case, where the APB is run with [ "provision", "-e", "broker_name=openshift-automation-service-broker" ], the name and namespace of the broker would be openshift-automation-service-broker.

@jmontleon jmontleon closed this Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants