Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dnsmasq/node dependency #20682

Merged

Conversation

ironcladlou
Copy link
Contributor

Port of an installer fix[1] for a RHEL environment bug[2] which has been
reproduced on Atomic Host environments. The dnsmasq service should start with
the node, but both services should then operate independently (e.g. stopping
dnsmasq should not stop the node service).

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1617976.

[1] openshift/openshift-ansible#6843
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1532960

Port of an installer fix[1] for a RHEL environment bug[2] which has been
reproduced on Atomic Host environments. The dnsmasq service should start with
the node, but both services should then operate independently (e.g. stopping
dnsmasq should not stop the node service).

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1617976.

[1] openshift/openshift-ansible#6843
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1532960
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 17, 2018
@ironcladlou
Copy link
Contributor Author

/cc @sdodson

@sdodson
Copy link
Member

sdodson commented Aug 17, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ironcladlou, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2018
@openshift-merge-robot openshift-merge-robot merged commit 6247c2c into openshift:master Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants