make ext test need for existing cluster painfully obvious #20968
Conversation
openshift-ci-robot
added
sig/developer-experience
size/XS
|
/retest |
test/extended/setup.sh
Outdated
| @@ -40,6 +40,11 @@ function os::test::extended::focus () { | |||
| # and then tests are executed. Tests that depend on fine grained setup should | |||
| # be done in other contexts. | |||
| function os::test::extended::setup () { | |||
| echo "" | |||
| os::log::info "REMINDER, EXTENDED TESTS NO LONGER START A CLUSTER." | |||
There was a problem hiding this comment.
Perfect opportunity to use os::log::warning
There was a problem hiding this comment.
switch to warning pushed
gabemontero
force-pushed
the
ext-tst-warn
branch
from
c9b0aaa
to
297faec
Compare
|
bump @smarterclayton @bparees ... the new log now leverages os::log::warning |
test/extended/setup.sh
Outdated
| echo "" | ||
| os::log::warning "REMINDER, EXTENDED TESTS NO LONGER START A CLUSTER." | ||
| os::log::warning "THE CLUSTER REFERENCED BY THE 'KUBECONFIG' ENV VAR IS USED." | ||
| echo "" |
There was a problem hiding this comment.
align the indentation please
gabemontero
force-pushed
the
ext-tst-warn
branch
2 times, most recently
from
bebdb12
to
bd19ffc
Compare
gabemontero
force-pushed
the
ext-tst-warn
branch
from
bd19ffc
to
e5d816a
Compare
|
indentation adjusted |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/test integration |
|
@gabemontero: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@smarterclayton per recent email thread
@openshift/sig-developer-experience fyi