add "pull" action to docker registry client context #21965
Conversation
openshift-ci-robot
added
the
size/XS
|
I was pretty sure that pull was always added. Did that get lost during a refactor? |
pkg/oc/cli/image/append/append.go
Outdated
| @@ -212,9 +213,9 @@ func (o *AppendImageOptions) Run() error { | |||
| return err | |||
| } | |||
| creds := dockercredentials.NewLocal() | |||
| ctx := context.Background() | |||
| ctx := apirequest.NewContext() | |||
There was a problem hiding this comment.
Wanted parity with the way image/mirror does it.
juanvallejo
force-pushed
the
jvallejo/fix-authentication-adm-release-new
branch
from
6d02ed9
to
6cb8902
Compare
"pull" has not been there, at least since commit 9b4b33618d93650070698b74ea62370c606d712e which was the last time this file was moved to its current location (9b4b336) |
|
Not in this code, in the place where we initialize the context (in the
registry client code).
|
|
@smarterclayton it looks like we only add "pull" at the registryclient level if no other actions were specified: https://github.com/openshift/origin/blob/master/pkg/image/registryclient/client.go#L311 |
|
/retest |
6 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juanvallejo, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1662088
cc @soltysh @smarterclayton