Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: <carry>: protect key openshift namespaces #21976

Merged
merged 2 commits into from Feb 8, 2019

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Feb 6, 2019

Given an operator based installation, the only two namespaces that need to be protected are openshift-config (user defined information that we cannot recreate) and openshift-cluster-version (the CVO which is responsible for recreating all the rest).

/assign @derekwaynecarr @smarterclayton

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 6, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2019
@derekwaynecarr
Copy link
Member

i am inclined to also protect openshift-cluster-api

/cc @enxebre for input.

@deads2k
Copy link
Contributor Author

deads2k commented Feb 6, 2019

i am inclined to also protect openshift-cluster-api

/cc @enxebre for input.

Only if deleting that namespace actually results in some cluster change and I wouldn't expect it to. The API driving machines ought to be cluster scoped

@enxebre
Copy link
Member

enxebre commented Feb 6, 2019

Only if deleting that namespace actually results in some cluster change and I wouldn't expect it to.
The API driving machines ought to be cluster scoped

openshift-cluster-api contains all the controllers watching machine resources plus the machine objects generated by the installer. The reason for Machines to be namespaced is the use case where one root cluster colocate machine objects managing child clusters. Protect it sounds reasonable.
Fwiw We are considering to rename it to openshift-machine-api

@derekwaynecarr
Copy link
Member

@deads2k deleting that namespace will delete all computers managing the cluster in IPI mode, and all elastic compute in a UPI install.

@deads2k
Copy link
Contributor Author

deads2k commented Feb 6, 2019

@deads2k deleting that namespace will delete all computers managing the cluster in IPI mode, and all elastic compute in a UPI install.

Which name would you like to protect? Since it's baked into our fork of kube, renaming is possible, but painful during the transition.

@deads2k deads2k added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2019
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 7, 2019
@deads2k
Copy link
Contributor Author

deads2k commented Feb 7, 2019

If you change the name, be sure to update this patch.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k
Copy link
Contributor Author

deads2k commented Feb 7, 2019

/retest

@derekwaynecarr
Copy link
Member

we can send a follow-up.

@deads2k
Copy link
Contributor Author

deads2k commented Feb 7, 2019

/retest

1 similar comment
@deads2k
Copy link
Contributor Author

deads2k commented Feb 7, 2019

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 8, 2019

@deads2k: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-all 6c7efee link /test e2e-aws-all
ci/prow/e2e-aws-builds 6c7efee link /test e2e-aws-builds
ci/prow/e2e-aws-image-ecosystem 6c7efee link /test e2e-aws-image-ecosystem
ci/prow/e2e-aws-image-registry 6c7efee link /test e2e-aws-image-registry
ci/prow/e2e-conformance-k8s 6c7efee link /test e2e-conformance-k8s
ci/prow/launch-aws 6c7efee link /test launch-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mfojtik
Copy link
Member

mfojtik commented Feb 8, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit 104a1aa into openshift:master Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants