New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UPSTREAM: <carry>: protect key openshift namespaces #21976
Conversation
i am inclined to also protect openshift-cluster-api /cc @enxebre for input. |
Only if deleting that namespace actually results in some cluster change and I wouldn't expect it to. The API driving machines ought to be cluster scoped |
|
@deads2k deleting that namespace will delete all computers managing the cluster in IPI mode, and all elastic compute in a UPI install. |
Which name would you like to protect? Since it's baked into our fork of kube, renaming is possible, but painful during the transition. |
If you change the name, be sure to update this patch. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
we can send a follow-up. |
/retest |
1 similar comment
/retest |
@deads2k: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
Given an operator based installation, the only two namespaces that need to be protected are
openshift-config
(user defined information that we cannot recreate) andopenshift-cluster-version
(the CVO which is responsible for recreating all the rest)./assign @derekwaynecarr @smarterclayton