Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish CRD openapi #22045

Merged
merged 6 commits into from
Feb 26, 2019
Merged

Publish CRD openapi #22045

merged 6 commits into from
Feb 26, 2019

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Feb 14, 2019

/assign @deads2k @sttts

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 14, 2019
@mfojtik
Copy link
Contributor

mfojtik commented Feb 15, 2019

/retest

@soltysh soltysh changed the title WIP: Publish CRD openapi Publish CRD openapi Feb 15, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 15, 2019
@deads2k
Copy link
Contributor

deads2k commented Feb 15, 2019

I think I get it. mostly net new.

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 15, 2019
@deads2k
Copy link
Contributor

deads2k commented Feb 15, 2019

/retest

@deads2k
Copy link
Contributor

deads2k commented Feb 15, 2019

aws resources out

/retest

@deads2k
Copy link
Contributor

deads2k commented Feb 15, 2019

/retest

1 similar comment
@soltysh
Copy link
Contributor Author

soltysh commented Feb 15, 2019

/retest

@deads2k
Copy link
Contributor

deads2k commented Feb 15, 2019

aws-serial is good except for a known flake

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@soltysh
Copy link
Contributor Author

soltysh commented Feb 16, 2019

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@sttts
Copy link
Contributor

sttts commented Feb 25, 2019

/retest

@soltysh
Copy link
Contributor Author

soltysh commented Feb 25, 2019

/test launch-aws

@sttts
Copy link
Contributor

sttts commented Feb 25, 2019

/retest

@soltysh
Copy link
Contributor Author

soltysh commented Feb 25, 2019

/test launch-aws

@soltysh
Copy link
Contributor Author

soltysh commented Feb 25, 2019

/retest

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2019
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@soltysh soltysh added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2019
@soltysh
Copy link
Contributor Author

soltysh commented Feb 25, 2019

/test launch-aws

@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2019
@soltysh soltysh added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2019
@soltysh soltysh added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2019
@sttts
Copy link
Contributor

sttts commented Feb 26, 2019

/retest

@deads2k
Copy link
Contributor

deads2k commented Feb 26, 2019

https://openshift-gce-devel.appspot.com/pr/22045 indicates success on be76fbb

@deads2k deads2k merged commit 7f67778 into openshift:master Feb 26, 2019
@soltysh soltysh deleted the crd-publish-openapi branch February 26, 2019 12:56
@soltysh soltysh mentioned this pull request Mar 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sttts sttts sttts left review comments

@deads2k deads2k Awaiting requested review from deads2k

@enj enj Awaiting requested review from enj

Assignees

@sttts sttts

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@soltysh @mfojtik @deads2k @openshift-bot @sttts @smarterclayton @openshift-ci-robot