UPSTREAM: 00000: wait for CRD discovery to be successful once before … #22178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reporting success
openshift-ci-robot
added
size/S
mfojtik
reviewed
Feb 27, 2019
| // may all be present. | ||
| _, serverGroupsAndResources, discoveryErr := crdClient.Discovery().ServerGroupsAndResources() | ||
| if discoveryErr != nil { | ||
| glog.V(2).Info(discoveryErr) |
There was a problem hiding this comment.
can we add some context there `glog.V(2).Infof("Failed to fetch discovery: %v", err)
mfojtik
reviewed
Feb 27, 2019
| } | ||
|
|
There was a problem hiding this comment.
wonder what are these, 🤷♂️
|
/lgtm (unhold and retag when you fix the glog) |
openshift-ci-robot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, mfojtik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…reporting success
We need to tolerate discovery errors from aggregated APIs that can be caused by networking or other issues.