test/extented/prometheus: Relax alert firing smoke test

[brancz]

Pending alerts are not necessarily worth a test failure, firing alerts definitely are, but pending alerts can happen due to various reasons and are too flaky to fail on, in some cases it's even expected to see pending alerts from time to time. The fact that they may not be firing would validate that the for value has been chosen appropriately.

@mxinden @paulfantom @squat @s-urbaniak @metalmatze

[brancz]

/retest

[brancz]

/retest

[brancz]

/retest

[mxinden]

@paulfantom and I have been looking into how we can catch alerts that would fire on a long running cluster, but have a long for (e.g. 10 minutes), which would not be reached on the test cluster. @paulfantom tried to force the test to at least run at the very end of the entire test run, but as far as I remember that was not possible (correct me if I am wrong).

This patch sounds reasonable. Any thoughts on how we could still achieve the above? Maybe check for pending alerts for a longer time period?

[paulfantom]

That is right, I was looking into running this test as the last one in whole test suite but I didn't found any solution when using it in e2e-aws. Possible alternative would be to move it into e2e-aws-serial but this one isn't running everywhere.

[brancz]

/retest

[paulfantom]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, paulfantom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• test/extended/prometheus/OWNERS [brancz,paulfantom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[brancz]

/retest

[brancz]

/retest

[smarterclayton]

/cherrypick release-4.1

[openshift-cherrypick-robot]

@smarterclayton: new pull request created: #22839

In response to this:

/cherrypick release-4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.