Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove admission API registration from scheme #22991

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented May 31, 2019

Trying to prune out various API groups. The admission APIs are isolated and shouldn't be in the main scheme.

/assign @soltysh

@openshift-ci-robot openshift-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 31, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2019
@deads2k deads2k force-pushed the move-31-remove-admission-registration branch from 31ad939 to 57c8497 Compare June 1, 2019 17:02
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 1, 2019
@deads2k deads2k added the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2019
@deads2k
Copy link
Contributor Author

deads2k commented Jun 1, 2019

completes the scheme separation arc. tagging

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k
Copy link
Contributor Author

deads2k commented Jun 1, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit 579f5bb into openshift:master Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants