Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase the wait for the service upgrade e2e test for LB #23160

Merged
merged 1 commit into from
Jun 14, 2019
Merged

Increase the wait for the service upgrade e2e test for LB #23160

merged 1 commit into from
Jun 14, 2019

Conversation

smarterclayton
Copy link
Contributor

@smarterclayton smarterclayton commented Jun 13, 2019 •
edited
Loading

In heavily contended AWS accounts, it can take more than 2m for an
LB to get created and pick up entries.

Should address bug 1690087

/cherrypick release-4.1

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 13, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2019
@smarterclayton smarterclayton force-pushed the increase_lb_wait branch 2 times, most recently from a32b1cc to 3926855 Compare June 13, 2019 15:51
@ironcladlou
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ironcladlou, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@smarterclayton
UPSTREAM: 78992: Increase the wait for the service upgrade e2e test f…
db8cd7a 
…or LB

In heavily contended AWS accounts, it can take more than 2m for an
LB to get created and pick up entries.
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2019
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@smarterclayton smarterclayton added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2019
@knobunc
Copy link
Contributor

knobunc commented Jun 13, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit 2d4a4b9 into openshift:master Jun 14, 2019
@smarterclayton
Copy link
Contributor Author

/cherrypick release-4.1

1 similar comment
@smarterclayton
Copy link
Contributor Author

/cherrypick release-4.1

@openshift-cherrypick-robot
Copy link

@smarterclayton: #23160 failed to apply on top of branch "release-4.1":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	vendor/k8s.io/kubernetes/test/e2e/upgrades/services.go
Falling back to patching base and 3-way merge...
Auto-merging vendor/k8s.io/kubernetes/test/e2e/upgrades/services.go
CONFLICT (content): Merge conflict in vendor/k8s.io/kubernetes/test/e2e/upgrades/services.go
Patch failed at 0001 UPSTREAM: 78992: Increase the wait for the service upgrade e2e test for LB

In response to this:

/cherrypick release-4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@smarterclayton smarterclayton mentioned this pull request Jun 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@ironcladlou ironcladlou

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@smarterclayton @ironcladlou @openshift-ci-robot @openshift-bot @knobunc @openshift-cherrypick-robot @openshift-merge-robot