Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto olm test case OCP-23440: the end user can use operator resources #23365

Merged
merged 1 commit into from Jan 6, 2020

Conversation

jianzhangbjz
Copy link
Contributor

@bparees @ecordell @njhale As title, please have a review. One question, what's the best solution to switch between cluster-admin user and common user? Do we have any code implement it? Thanks! cc: @cuipinghuo @bandrade @scolange @chengzhang1016 @zihantang-rh @emmajiafan

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 11, 2019
@bparees
Copy link
Contributor

bparees commented Jul 11, 2019

what's the best solution to switch between cluster-admin user and common user

using "oc.AsAdmin()" to perform actions as kubeadmin and just oc.X() to do it as the normal e2e user.

@jianzhangbjz
Copy link
Contributor Author

@bparees Got it, thanks! @njhale Could you help review this PR? Thanks!

@jianzhangbjz
Copy link
Contributor Author

/assign @bparees @njhale

@jianzhangbjz
Copy link
Contributor Author

/test e2e-aws

@jianzhangbjz
Copy link
Contributor Author

Try to fix below errors:

fail [github.com/openshift/origin/test/extended/operators/olm.go:96]: Unexpected error:
    <*util.ExitError | 0xc004214450>: {
        Cmd: "oc --namespace=e2e-test-olm-23440-fnwcv --config=/tmp/admin.kubeconfig create -f /tmp/e2e-test-olm-23440-fnwcv-config.json",
        StdErr: "error: the namespace from the provided object \"openshift-marketplace\" does not match the namespace \"e2e-test-olm-23440-fnwcv\". You must pass '--namespace=openshift-marketplace' to perform this operation.",

@jianzhangbjz
Copy link
Contributor Author

/retest

1 similar comment
@jianzhangbjz
Copy link
Contributor Author

/retest

@jianzhangbjz
Copy link
Contributor Author

jianzhangbjz commented Jul 18, 2019

Add spec.source field to cover the latest csc changes in 4.2.

fail [github.com/openshift/origin/test/extended/operators/olm.go:96]: Unexpected error:
    <*util.ExitError | 0xc000023dd0>: {
        Cmd: "oc --config=/tmp/admin.kubeconfig create -f /tmp/e2e-test-olm-23440-2ndqf-config.json",
        StdErr: "The CatalogSourceConfig \"test-operator\" is invalid: []: Invalid value: map[string]interface {}{\"apiVersion\":\"operators.coreos.com/v1\", \"kind\":\"CatalogSourceConfig\", \"metadata\":map[string]interface {}{\"creationTimestamp\":\"2019-07-18T03:07:37Z\", \"generation\":1, \"name\":\"test-operator\", \"namespace\":\"openshift-marketplace\", \"uid\":\"3213d429-a909-11e9-9d9d-12dda7ad6924\"}, \"spec\":map[string]interface {}{\"packages\":\"etcd\", \"targetNamespace\":\"e2e-test-olm-23440-2ndqf\"}}: validation failure list:\nspec.source in body is required"

@jianzhangbjz
Copy link
Contributor Author

/retest

@jianzhangbjz
Copy link
Contributor Author

/retest

@jianzhangbjz
Copy link
Contributor Author

/test e2e-aws

@jianzhangbjz
Copy link
Contributor Author

@bparees @njhale Could help review this PR and give approve if it looks good? Thanks!

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 26, 2019
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 4, 2019
@jianzhangbjz
Copy link
Contributor Author

/test e2e-aws-serial

@jianzhangbjz
Copy link
Contributor Author

@bparees @njhale Could help review this PR and give approve if it looks good? Thanks!

@jianzhangbjz
Copy link
Contributor Author

jianzhangbjz commented Sep 3, 2019

@bparees @njhale Could help review this PR and give approve if it looks good? Thanks! It's in Pending status for a long time. :(

@bparees
Copy link
Contributor

bparees commented Sep 3, 2019

@jianzhangbjz i'm not actually on the OLM team, so should be reviewed by @njhale or @ecordell or someone else from that team.

@jianzhangbjz
Copy link
Contributor Author

@bparees Thanks! I thought @njhale @ecordell may be haven't the merging permission. So, I message you. @njhale @ecordell Could you help have a review add the /lgtm label if it looks good? Thanks!

@bparees
Copy link
Contributor

bparees commented Sep 3, 2019

/approve

now they can definitely merge it :)

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2019
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@jianzhangbjz
Copy link
Contributor Author

jianzhangbjz commented Dec 13, 2019

@smarterclayton @knobunc Could you help have a review? Thanks!

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 13, 2019
@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 15, 2019
@jianzhangbjz
Copy link
Contributor Author

Rebase it. @ecordell @njhale @emmajiafan Could you help add the lgtm label? Thanks!

@jianzhangbjz
Copy link
Contributor Author

/test e2e-aws-fips

@jianzhangbjz
Copy link
Contributor Author

/retest

1 similar comment
@jianzhangbjz
Copy link
Contributor Author

/retest

@emmajiafan
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, emmajiafan, jianzhangbjz, njhale, shawn-hurley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 6, 2020

@jianzhangbjz: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-builds 9ce29bf link /test e2e-aws-builds
ci/prow/e2e-aws-upgrade 9ce29bf link /test e2e-aws-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit b600fb9 into openshift:master Jan 6, 2020
@jianzhangbjz jianzhangbjz deleted the olm-23440 branch January 8, 2020 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet