New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG 1753012: UPSTREAM: 82830: Do not query the cloud if PV has all the labels #23835
BUG 1753012: UPSTREAM: 82830: Do not query the cloud if PV has all the labels #23835
Conversation
@jsafrane: This pull request references Bugzilla bug 1753012, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jsafrane: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
04be360
to
10e4efe
Compare
Fixed not to require pkg/controller/volume/persistentvolume/util, which is avalable only in 1.16
10e4efe
to
603bd86
Compare
@jsafrane: This pull request references Bugzilla bug 1753012, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
@jsafrane: This pull request references Bugzilla bug 1753012, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
603bd86
to
f2e1ed2
Compare
@jsafrane: An error was encountered searching for bug 1753012 on the Bugzilla server at https://bugzilla.redhat.com:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
f2e1ed2
to
df97c72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @deads2k |
df97c72
to
1f24b29
Compare
/bugzilla refresh |
@jsafrane: This pull request references Bugzilla bug 1753012, which is valid. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
/test e2e-gcp |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, deads2k, huffmanca, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jsafrane: All pull requests linked via external trackers have merged. Bugzilla bug 1753012 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
https://bugzilla.redhat.com/show_bug.cgi?id=1753012
kubernetes/kubernetes#82830
Some backport changes were necessary,
pkg/controller/volume/persistentvolume/util
is not available in 1.14 andannDynamicallyProvisioned
is private in pv_controller.goWIP: remove the first debug commit