Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG 1753012: UPSTREAM: 82830: Do not query the cloud if PV has all the labels #23835

Merged
merged 1 commit into from Sep 20, 2019

Conversation

jsafrane
Copy link
Contributor

@jsafrane jsafrane commented Sep 20, 2019

https://bugzilla.redhat.com/show_bug.cgi?id=1753012
kubernetes/kubernetes#82830

Some backport changes were necessary, pkg/controller/volume/persistentvolume/util is not available in 1.14 and annDynamicallyProvisioned is private in pv_controller.go

WIP: remove the first debug commit

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 20, 2019
@openshift-ci-robot
Copy link

@jsafrane: This pull request references Bugzilla bug 1753012, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

WIP: Bug 1753012: UPSTREAM: 82830: Do not query the cloud if PV has all the labels

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 20, 2019
@jsafrane jsafrane changed the title WIP: Bug 1753012: UPSTREAM: 82830: Do not query the cloud if PV has all the labels WIP: UPSTREAM: 82830: Do not query the cloud if PV has all the labels Sep 20, 2019
@openshift-ci-robot
Copy link

@jsafrane: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

WIP: UPSTREAM: 82830: Do not query the cloud if PV has all the labels

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 20, 2019
Fixed not to require pkg/controller/volume/persistentvolume/util, which is
avalable only in 1.16
@jsafrane jsafrane changed the title WIP: UPSTREAM: 82830: Do not query the cloud if PV has all the labels UPSTREAM: 82830: Do not query the cloud if PV has all the labels Sep 20, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 20, 2019
@jsafrane jsafrane changed the title UPSTREAM: 82830: Do not query the cloud if PV has all the labels BUG 1753012: UPSTREAM: 82830: Do not query the cloud if PV has all the labels Sep 20, 2019
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 20, 2019
@openshift-ci-robot
Copy link

@jsafrane: This pull request references Bugzilla bug 1753012, which is invalid:

  • expected the bug to target the "4.2.0" release, but it targets "4.3.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

BUG 1753012: UPSTREAM: 82830: Do not query the cloud if PV has all the labels

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link

@jsafrane: This pull request references Bugzilla bug 1753012, which is invalid:

  • expected the bug to target the "4.2.0" release, but it targets "4.3.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

BUG 1753012: UPSTREAM: 82830: Do not query the cloud if PV has all the labels

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@jsafrane: An error was encountered searching for bug 1753012 on the Bugzilla server at https://bugzilla.redhat.com:

Get https://bugzilla.redhat.com/rest/bug/1753012?api_key=CENSORED: dial tcp: i/o timeout
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

BUG 1753012: UPSTREAM: 82830: Do not query the cloud if PV has all the labels

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2019
@bertinatto
Copy link
Member

/assign @deads2k
for approval

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2019
@jsafrane
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot
Copy link

@jsafrane: This pull request references Bugzilla bug 1753012, which is valid.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 20, 2019
@huffmanca
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2019
@jsafrane
Copy link
Contributor Author

/test e2e-gcp

@deads2k
Copy link
Contributor

deads2k commented Sep 20, 2019

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, deads2k, huffmanca, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2019
@openshift-merge-robot openshift-merge-robot merged commit c3e5798 into openshift:master Sep 20, 2019
@openshift-ci-robot
Copy link

@jsafrane: All pull requests linked via external trackers have merged. Bugzilla bug 1753012 has been moved to the MODIFIED state.

In response to this:

BUG 1753012: UPSTREAM: 82830: Do not query the cloud if PV has all the labels

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants