Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: run router header test on AWS/GCP/Azure only #24145

Conversation

frobware
Copy link
Contributor

This is a follow-up to #24093 which breaks (or flakes on) OpenStack.

Rather than trying to run down all the flakes on all the platforms in
4.3 I've changed the router header test to run against the following
platforms only:

  • AWS
  • Azure
  • GCP

A new BZ[1] has been opened to ensure that the other platforms are not
forgotten.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1772125

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 13, 2019
@frobware
Copy link
Contributor Author

/cc @mandre @ironcladlou

@ironcladlou
Copy link
Contributor

To avoid doing anything at all on those platforms (and also providing output about the skipping), I believe you can add a g.Skip() call during a platform check added to g.BeforeEach()

This is a follow-up to:

  openshift#24093

which breaks (or flakes on) OpenStack.

Rather than trying to run down all the flakes on all the platforms in
4.3 I've changed the router header test to run against the following
platforms only:

- AWS
- Azure
- GCP

A new BZ[1] has been opened to ensure that the other platforms are not
forgotten.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1772125
@frobware frobware force-pushed the skip-openstack-for-router-header-test branch from d947098 to 0e40910 Compare November 14, 2019 09:18
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 14, 2019
@frobware
Copy link
Contributor Author

To avoid doing anything at all on those platforms (and also providing output about the skipping), I believe you can add a g.Skip() call during a platform check added to g.BeforeEach()

Done in 0e40910

@mandre
Copy link
Member

mandre commented Nov 14, 2019

Thanks for looking into it. LGTM.

@ironcladlou
Copy link
Contributor

Thanks!

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frobware, ironcladlou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 72407af into openshift:master Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants