Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug 1784848: fix up ruby-25-centos7 tag check logic #24322

Merged
merged 1 commit into from Dec 18, 2019
Merged

bug 1784848: fix up ruby-25-centos7 tag check logic #24322

merged 1 commit into from Dec 18, 2019

Conversation

bparees
Copy link
Contributor

@bparees bparees commented Dec 18, 2019

No description provided.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 18, 2019
@openshift-ci-robot
Copy link

@bparees: This pull request references Bugzilla bug 1784848, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

bug 1784848: fix up ruby-25-centos7 tag check logic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 18, 2019
@bparees
Copy link
Contributor Author

bparees commented Dec 18, 2019

/assign @adambkaplan

adambkaplan
adambkaplan approved these changes Dec 18, 2019
View reviewed changes
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2019
@adambkaplan
Copy link
Contributor

off to the races with #24319

@mfojtik mfojtik mentioned this pull request Dec 18, 2019
Merged
@adambkaplan
Copy link
Contributor

/cherry-pick release-4.3

/cherry-pick release-4.2

@openshift-cherrypick-robot
Copy link

@adambkaplan: once the present PR merges, I will cherry-pick it on top of release-4.3 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.3

/cherry-pick release-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bparees
Copy link
Contributor Author

bparees commented Dec 18, 2019

/cherry-pick release-4.1
/cherry-pick release-3.11

@openshift-cherrypick-robot
Copy link

@bparees: once the present PR merges, I will cherry-pick it on top of release-4.1 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.1
/cherry-pick release-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bparees
Copy link
Contributor Author

bparees commented Dec 18, 2019

/cherry-pick release-3.11

@openshift-cherrypick-robot
Copy link

@bparees: once the present PR merges, I will cherry-pick it on top of release-3.11 in a new PR and assign it to you.

In response to this:

/cherry-pick release-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bparees
Copy link
Contributor Author

bparees commented Dec 18, 2019

/cherry-pick release-4.2

@openshift-cherrypick-robot
Copy link

@bparees: once the present PR merges, I will cherry-pick it on top of release-4.2 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bparees
Copy link
Contributor Author

bparees commented Dec 18, 2019

/test unit

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@smarterclayton
Copy link
Contributor

why did this break?

@bparees
Copy link
Contributor Author

bparees commented Dec 18, 2019

why did this break?

SCL team pushed new tags to the repository, so our very loose regex checking started failing when the imagestream imported more tags than we expected.

@bparees
Copy link
Contributor Author

bparees commented Dec 18, 2019

/test e2e-gcp

@bparees
Copy link
Contributor Author

bparees commented Dec 18, 2019

/test e2e-aws-fips

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2019
@openshift-ci-robot openshift-ci-robot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 18, 2019
@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 18, 2019
@bparees bparees added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@wking
Copy link
Member

wking commented Dec 18, 2019

#24319 has landed, and this PR already reverts its changes ✔️

unit failed. Error from here looks like a panic:

=== RUN   TestYAMLLimits/3MB_map_with_alias/utilyaml
coverage: 0.0% of statements
panic: test timed out after 3m0s

goroutine 70 [running]:
testing.(*M).startAlarm.func1()
	/usr/local/go/src/testing/testing.go:1377 +0x11c
created by time.goFunc
	/usr/local/go/src/time/sleep.go:168 +0x52

goroutine 1 [chan receive, 2 minutes]:
testing.(*T).Run(0xc000124000, 0xaf50f5, 0xe, 0xb12358, 0x0)
	/usr/local/go/src/testing/testing.go:961 +0x68a
testing.runTests.func1(0xc000124000)
	/usr/local/go/src/testing/testing.go:1202 +0xa7
testing.tRunner(0xc000124000, 0xc000113cd8)
	/usr/local/go/src/testing/testing.go:909 +0x19a
testing.runTests(0xc00000e560, 0xf099d0, 0x1, 0x1, 0x0)
	/usr/local/go/src/testing/testing.go:1200 +0x522
testing.(*M).Run(0xc00002a380, 0x0)
	/usr/local/go/src/testing/testing.go:1117 +0x300
main.main()
	_testmain.go:94 +0x338

goroutine 6 [chan receive]:
github.com/openshift/origin/vendor/k8s.io/klog.(*loggingT).flushDaemon(0xf16180)
	/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/klog/klog.go:1018 +0xae
created by ...
...

@bparees
Copy link
Contributor Author

bparees commented Dec 18, 2019

/test unit

@bparees
Copy link
Contributor Author

bparees commented Dec 18, 2019

unit failed. Error from here looks like a panic:

@wking i don't think that has to do w/ this PR, do you?

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@mfojtik
Copy link
Member

mfojtik commented Dec 18, 2019

/hold

The number of changes in bindata seems off? Can we confirm it has the right data? Feel free to un-hold if yes.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2019
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 18, 2019
@mfojtik
Copy link
Member

mfojtik commented Dec 18, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2019
@bparees
Copy link
Contributor Author

bparees commented Dec 18, 2019

bindata fixed
/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, bparees, mfojtik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit a3d0eea into openshift:master Dec 18, 2019
@openshift-ci-robot
Copy link

@bparees: All pull requests linked via external trackers have merged. Bugzilla bug 1784848 has been moved to the MODIFIED state.

In response to this:

bug 1784848: fix up ruby-25-centos7 tag check logic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@adambkaplan: #24322 failed to apply on top of branch "release-4.3":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	test/extended/testdata/bindata.go
M	test/extended/testdata/cmd/test/cmd/builds.sh
Falling back to patching base and 3-way merge...
Auto-merging test/extended/testdata/cmd/test/cmd/builds.sh
CONFLICT (content): Merge conflict in test/extended/testdata/cmd/test/cmd/builds.sh
Auto-merging test/extended/testdata/bindata.go
CONFLICT (content): Merge conflict in test/extended/testdata/bindata.go
Patch failed at 0001 fix up ruby-25-centos7 tag check logic

In response to this:

/cherry-pick release-4.3

/cherry-pick release-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@bparees: #24322 failed to apply on top of branch "release-4.1":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	test/extended/testdata/bindata.go
A	test/extended/testdata/cmd/test/cmd/builds.sh
A	test/extended/testdata/cmd/test/cmd/testdata/application-template-dockerbuild.json
Falling back to patching base and 3-way merge...
Auto-merging test/extended/testdata/bindata.go
CONFLICT (content): Merge conflict in test/extended/testdata/bindata.go
Auto-merging test/cmd/builds.sh
CONFLICT (content): Merge conflict in test/cmd/builds.sh
Auto-merging examples/sample-app/application-template-stibuild.json
Patch failed at 0001 fix up ruby-25-centos7 tag check logic

In response to this:

/cherry-pick release-4.1
/cherry-pick release-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@bparees: #24322 failed to apply on top of branch "release-3.11":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	examples/sample-app/application-template-dockerbuild.json
M	test/extended/testdata/bindata.go
A	test/extended/testdata/cmd/test/cmd/builds.sh
A	test/extended/testdata/cmd/test/cmd/testdata/application-template-dockerbuild.json
Falling back to patching base and 3-way merge...
Auto-merging test/extended/testdata/bindata.go
CONFLICT (content): Merge conflict in test/extended/testdata/bindata.go
Auto-merging test/cmd/builds.sh
CONFLICT (content): Merge conflict in test/cmd/builds.sh
Auto-merging examples/sample-app/application-template-stibuild.json
Auto-merging examples/sample-app/application-template-dockerbuild.json
Patch failed at 0001 fix up ruby-25-centos7 tag check logic

In response to this:

/cherry-pick release-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@bparees: #24322 failed to apply on top of branch "release-4.2":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	test/extended/testdata/bindata.go
M	test/extended/testdata/cmd/test/cmd/builds.sh
Falling back to patching base and 3-way merge...
Auto-merging test/extended/testdata/cmd/test/cmd/builds.sh
CONFLICT (content): Merge conflict in test/extended/testdata/cmd/test/cmd/builds.sh
Auto-merging test/extended/testdata/bindata.go
CONFLICT (content): Merge conflict in test/extended/testdata/bindata.go
Patch failed at 0001 fix up ruby-25-centos7 tag check logic

In response to this:

/cherry-pick release-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bparees bparees deleted the tags branch December 22, 2019 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambkaplan adambkaplan adambkaplan approved these changes

@ironcladlou ironcladlou Awaiting requested review from ironcladlou

Assignees

@mfojtik mfojtik

@adambkaplan adambkaplan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@bparees @openshift-ci-robot @adambkaplan @openshift-cherrypick-robot @openshift-bot @smarterclayton @wking @mfojtik @openshift-merge-robot