Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes panic in openshift-test cmd #24438

Closed
wants to merge 1 commit into from
Closed

fixes panic in openshift-test cmd #24438

wants to merge 1 commit into from

Conversation

p0lyn0mial
Copy link
Contributor

This PR fixes the following panic when running openshift-tests run openshift/conformance/serial --dry-run 

goroutine 1 [running, locked to thread]:                                                                                                                                                                                                                                                                            
runtime/debug.Stack(0x6d, 0xc0038c58c0, 0x2a0)                                                                                                                                                                                                                                                                      
        /usr/local/go/src/runtime/debug/stack.go:24 +0x9d                                                                                                                                                                                                                                                           
github.com/openshift/origin/test/extended/util.FatalErr(0x567ff20, 0xc0039910e0)                                                                                                                                                                                                                                    
        /Users/lszaszki/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/test/extended/util/client.go:643 +0x26                                                                                                                                                                  
github.com/openshift/origin/test/extended/util.(*CLI).AdminConfig(0xc0039bf000, 0xa)                                                                                                                                                                                                                                
        /Users/lszaszki/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/test/extended/util/client.go:443 +0x65                                                                                                                                                                  
github.com/openshift/origin/test/extended/cli.glob..func4()                                                                                                                                                                                                                                                         
        /Users/lszaszki/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/test/extended/cli/explain.go:332 +0x9e                                                                                                                                                                  
github.com/openshift/origin/vendor/github.com/onsi/ginkgo/internal/suite.(*Suite).PushContainerNode(0xc0002914f0, 0x5f44669, 0x10, 0x61d5558, 0x0, 0x9918b62, 0x80, 0x148, 0xc0039e33b0, 0x8c)                                                                                                                      
        /Users/lszaszki/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/github.com/onsi/ginkgo/internal/suite/suite.go:144 +0x158                                                                                                                                        
github.com/openshift/origin/vendor/github.com/onsi/ginkgo.Describe(0x5f44669, 0x10, 0x61d5558, 0xc0038a8d01)                                                                                                                                                                                                        
        /Users/lszaszki/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/github.com/onsi/ginkgo/ginkgo_dsl.go:293 +0xaa                                                                                                                                                   
github.com/openshift/origin/test/extended/cli.init()                                                                                                                                                                                                                                                                
        /Users/lszaszki/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/test/extended/cli/explain.go:328 +0xb5                                                                                                                                                                  
                                                                                                                                                                                                                                                                                                                    
Jan 22 09:43:29.262: FAIL: open : no such file or directory                                                                                                                                                                                                                                                         
                                                                                                                                                                                                                                                                                                                    
Full Stack Trace                                                                                                                                                                                                                                                                                                    
github.com/openshift/origin/test/extended/util.FatalErr(0x567ff20, 0xc0039910e0)                                                                                                                                                                                                                                    
        /Users/lszaszki/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/test/extended/util/client.go:644 +0x118                                                                                                                                                                 
github.com/openshift/origin/test/extended/util.(*CLI).AdminConfig(0xc0039bf000, 0xa)                                                                                                                                                                                                                                
        /Users/lszaszki/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/test/extended/util/client.go:443 +0x65                                                                                                                                                                  
github.com/openshift/origin/test/extended/cli.glob..func4()                                                                                                                                                                                                                                                         
        /Users/lszaszki/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/test/extended/cli/explain.go:332 +0x9e                                                                                                                                                                  
github.com/openshift/origin/test/extended/cli.init()                                                                                                                                                                                                                                                                
        /Users/lszaszki/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/test/extended/cli/explain.go:328 +0xb5                                                                                                                                                                  
Jan 22 09:43:30.652: INFO: Could not get network operator configuration: not adding any plugin-specific skips                                                                                                                                                                                                       
W0122 09:43:30.770256   88003 test_context.go:410] Unable to find in-cluster config, using default host : http://127.0.0.1:8080

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 22, 2020
p0lyn0mial
p0lyn0mial commented Jan 22, 2020
View reviewed changes
test/extended/cli/explain.go
@@ -329,7 +329,6 @@ var _ = g.Describe("[cli] oc explain", func() {
defer g.GinkgoRecover()

oc := exutil.NewCLI("oc-explain", exutil.KubeConfigPath())
crdClient := apiextensionsclientset.NewForConfigOrDie(oc.AdminConfig())
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oc.AdminConfig loads a config file from a disk - this caused panic when the config file wasn't present. Having a config is not always required for example when passing dry-run flag.

I glanced over test/extended just to see if the other tests don't load AdminConfig too early.

@p0lyn0mial
Copy link
Contributor Author

/assign @sttts

@sttts
Copy link
Contributor

sttts commented Jan 22, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@p0lyn0mial
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

16 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@smarterclayton
Copy link
Contributor

/hold

This is fixed in another LGTM'd PR

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2020
@smarterclayton smarterclayton removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2020
@p0lyn0mial
Copy link
Contributor Author

closing as it was fixed in #24445

@p0lyn0mial p0lyn0mial closed this Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@bparees bparees Awaiting requested review from bparees

Assignees

@sttts sttts

Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@p0lyn0mial @sttts @openshift-ci-robot @openshift-bot @smarterclayton