Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Generate test name updates rather than calculate dynamically #24445

Merged
merged 3 commits into from Jan 24, 2020
Merged

test: Generate test name updates rather than calculate dynamically #24445

merged 3 commits into from Jan 24, 2020

Conversation

smarterclayton
Copy link
Contributor

@smarterclayton smarterclayton commented Jan 22, 2020 •
edited

It is expensive to perform 100 checks against 1k names on every startup.
Instead, move these to generated files that can be reviewed out of bounds
on change. Add them to generated-bindata for verification and regen.

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 22, 2020
@smarterclayton
Copy link
Contributor Author

/retest

@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 22, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jan 22, 2020
@smarterclayton smarterclayton changed the title test: Remove regexes in the wildcard selection, they are expensive test: Generate test name updates rather than calculate dynamically Jan 23, 2020
@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 23, 2020
@smarterclayton smarterclayton force-pushed the remove_test_wildcards branch 3 times, most recently from 698f7c8 to 4cceaeb Compare January 23, 2020 03:33
@smarterclayton
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@smarterclayton
Copy link
Contributor Author

/retest

@smarterclayton smarterclayton force-pushed the remove_test_wildcards branch 2 times, most recently from 624aac6 to 208ff9f Compare January 23, 2020 18:48
@smarterclayton
test: Remove regexes in the wildcard selection, they are expensive
cdb5357 
We noticed a 2x CPU regression in e2e runs, and these are unfortunately
the culprit.
@smarterclayton
test: Generate test annotations rather than doing them dynamically
df6f5bd 
It is expensive to perform 100 checks against 1k names on every
startup. Instead, move these to generated files that can be reviewed
out of bounds on change. Add them to generated-bindata for verification
and regen.
@smarterclayton
test: Remove dependency on e2e in cloud config lookup
85a55fd 
Also move skip logic into provider initialization, and buffer a
small amount of suite output. GCP tests are excluded from core
infra, they are not used.
@smarterclayton
Copy link
Contributor Author

/test e2e-cmd

@smarterclayton smarterclayton added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

10 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@smarterclayton
Copy link
Contributor Author

/refresh

@smarterclayton
Copy link
Contributor Author

/test all

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@smarterclayton
Copy link
Contributor Author

Merging to reduce CPU use and unblock David.

@smarterclayton smarterclayton merged commit 66c82bb into openshift:master Jan 24, 2020
@openshift-ci-robot
Copy link

@smarterclayton: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-serial 85a55fd link /test e2e-aws-serial

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@p0lyn0mial p0lyn0mial mentioned this pull request Jan 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekwaynecarr derekwaynecarr derekwaynecarr left review comments

@gabemontero gabemontero Awaiting requested review from gabemontero

@ironcladlou ironcladlou Awaiting requested review from ironcladlou

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@smarterclayton @openshift-ci-robot @openshift-bot @derekwaynecarr