Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert Disable flaky tests on OpenStack b390f42a42 #24490

Merged
merged 1 commit into from Feb 15, 2020
Merged

Revert Disable flaky tests on OpenStack b390f42a42 #24490

merged 1 commit into from Feb 15, 2020

Conversation

pierreprinetti
Copy link
Member

As the network issue is expected to be now resolved, these tests
have no reason to be skipped.

Reverts #24330

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 3, 2020
@pierreprinetti
Copy link
Member Author

/cc @mandre @sdodson

@mandre
Copy link
Member

mandre commented Feb 3, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2020
@sdodson
Copy link
Member

sdodson commented Feb 3, 2020

/test e2e-openstack

@sdodson
Copy link
Member

sdodson commented Feb 3, 2020

/approve
@smarterclayton ptal

@pierreprinetti
Copy link
Member Author

/retest

@pierreprinetti
Copy link
Member Author

/test verify

/origin/test/extended/util/annotate/generated/' expecting success
FAILURE after 0.065s: hack/verify-generated-bindata.sh:16: executing 'git diff --quiet /go/src/github.com/openshift/origin/test/extended/util/annotate/generated/' expecting success: the command returned the wrong error code
There was no output from the command.
There was no error output from the command.

🤔

@pierreprinetti
Copy link
Member Author

/retest

@smarterclayton
Copy link
Contributor

Run hack/update-generated-bindata.sh and include that with this commit

@pierreprinetti
Revert Disable flaky tests on OpenStack b390f42
d52d669 
As the network issue is expected to be now [resolved][1], these tests
have no reason to be skipped.

Reverts openshift#24330

[1]: openshift/installer#3027
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2020
@pierreprinetti
Copy link
Member Author

/retest

2 similar comments
@pierreprinetti
Copy link
Member Author

/retest

@pierreprinetti
Copy link
Member Author

/retest

@pierreprinetti
Copy link
Member Author

/test e2e-cmd

Cluster operator authentication Degraded is True

🤷‍♂️

@pierreprinetti
Copy link
Member Author

/cc smarterclayton mandre

the LGTM got lost in the go generate fix

/meow

@openshift-ci-robot
Copy link

@pierreprinetti: cat image

In response to this:

/cc smarterclayton mandre

the LGTM got lost in the go generate fix

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mandre
Copy link
Member

mandre commented Feb 10, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2020
@pierreprinetti
Copy link
Member Author

/assign @smarterclayton

@sdodson sdodson added approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Feb 14, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: mandre, pierreprinetti, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdodson
Copy link
Member

sdodson commented Feb 14, 2020

This had been discussed at length on Slack, overriding flags to get this test back in.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit eff1cfd into openshift:master Feb 15, 2020
@pierreprinetti pierreprinetti deleted the revert_bug1763936 branch March 18, 2020 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandre mandre Awaiting requested review from mandre

@sdodson sdodson Awaiting requested review from sdodson

@bparees bparees Awaiting requested review from bparees

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@mandre mandre

@smarterclayton smarterclayton

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@pierreprinetti @mandre @sdodson @smarterclayton @openshift-ci-robot @openshift-bot @openshift-merge-robot