Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable flaky tests on OpenStack #24330

Merged
merged 1 commit into from
Dec 20, 2019

Conversation

pierreprinetti
Copy link
Member

In order to increase chances to get a voting CI for OpenStack soon, I
propose to skip Network Granular Check tests that are intermittently
failing on our infrastructure.

This commit must be reverted and the issue properly investigated once
the minimum result of a voting CI is achieved.

ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1763936
ref.: #24313

The bug reference is not in the PR title nor leading the commit message, because this proposed change does not fix it.

/assign @smarterclayton
/cc @knobunc

@danwinship Do you think this work for OpenStack? Sorry I am not familiar with the skip logic, and I could not find specific documentation on the matter.

In order to increase chances to get a voting CI for OpenStack soon, I
propose to skip Network Granular Check tests that are intermittently
failing on our infrastructure.

This commit must be reverted and the issue properly investigated once
the minimum result of a voting CI is achieved.

ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1763936
ref.: openshift#24313
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 19, 2019
@pierreprinetti
Copy link
Member Author

/retest

1 similar comment
@pierreprinetti
Copy link
Member Author

/retest

@smarterclayton
Copy link
Contributor

This is fine for me

@pierreprinetti
Copy link
Member Author

/retest

@pierreprinetti
Copy link
Member Author

/cherry-pick release-4.3

@openshift-cherrypick-robot

@pierreprinetti: once the present PR merges, I will cherry-pick it on top of release-4.3 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knobunc
Copy link
Contributor

knobunc commented Dec 19, 2019

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2019
@knobunc
Copy link
Contributor

knobunc commented Dec 19, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knobunc, pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nee1esh
Copy link

nee1esh commented Dec 19, 2019

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

11 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit da5f704 into openshift:master Dec 20, 2019
@nee1esh
Copy link

nee1esh commented Dec 20, 2019

/cherry-pick release-4.3

@openshift-cherrypick-robot

@nee1esh: new pull request created: #24340

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti pierreprinetti deleted the bug1763936 branch December 20, 2019 16:01
Gal-Zaidman pushed a commit to Gal-Zaidman/origin that referenced this pull request Dec 23, 2019
Those tests are constantly failing on our infrastructure
during conformance runs.

This commit is due to the removal of those test from the
Flaky on, openshift#24313.
And the PR from openstack who experience the same results
on there CI runs openshift#24330.

Signed-off-by: Gal Zaidman <gzaidman@redhat.com>
pierreprinetti added a commit to shiftstack/origin that referenced this pull request Feb 3, 2020
As the network issue is expected to be now [resolved][1], these tests
have no reason to be skipped.

Reverts openshift#24330

[1]: openshift/installer#3027
pierreprinetti added a commit to shiftstack/origin that referenced this pull request Feb 3, 2020
As the network issue is expected to be now [resolved][1], these tests
have no reason to be skipped.

Reverts openshift#24330

[1]: openshift/installer#3027
sallyom pushed a commit to sallyom/openshift-tests that referenced this pull request Feb 16, 2020
As the network issue is expected to be now [resolved][1], these tests
have no reason to be skipped.

Reverts openshift/origin#24330

[1]: openshift/installer#3027
tbuskey pushed a commit to tbuskey/origin that referenced this pull request Mar 19, 2020
As the network issue is expected to be now [resolved][1], these tests
have no reason to be skipped.

Reverts openshift#24330

[1]: openshift/installer#3027
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants