-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test/extended/util/disruption/frontends/frontends: match route contents by regexp, support OKD #24782
test/extended/util/disruption/frontends/frontends: match route contents by regexp, support OKD #24782
Conversation
…ts by regexp, support OKD
/cherrypick release-4.4 |
@vrutkovs: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton, vrutkovs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@vrutkovs: new pull request created: #24788 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Upgrade tests for routes expect the console page to contain "Red Hat OpenShift Container Platform" title. These tests fail for OKD releases due to different branding.
This PR adds
ExpectRegexp
option for Frontend struct and checks both for OCP and OKD signature so that OKD upgrades could be tested using the same code./cc @smarterclayton