Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.3] Bug 1821341: UPSTREAM: 88440: Report deleted pod status correctly #24841

Merged
merged 1 commit into from Apr 10, 2020
Merged

[release-4.3] Bug 1821341: UPSTREAM: 88440: Report deleted pod status correctly #24841

merged 1 commit into from Apr 10, 2020

Conversation

rphillips
Copy link
Contributor

Origin Reference: #24627

@openshift-ci-robot
Copy link

@rphillips: This pull request references Bugzilla bug 1821341, which is invalid:

  • expected the bug to target the "4.3.z" release, but it targets "4.4.0" instead
  • expected dependent Bugzilla bug 1810652 to target the "4.4.0" release, but it targets "4.5.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1821341: UPSTREAM: 88440: Report deleted pod status correctly

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 6, 2020
@rphillips
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot
Copy link

@rphillips: This pull request references Bugzilla bug 1821341, which is invalid:

  • expected dependent Bugzilla bug 1810652 to target the "4.4.0" release, but it targets "4.5.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rphillips
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 6, 2020
@openshift-ci-robot
Copy link

@rphillips: This pull request references Bugzilla bug 1821341, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.3.z) matches configured target release for branch (4.3.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1810722 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1810722 targets the "4.4.0" release, matching the expected (4.4.0) release
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sjenning
Copy link
Contributor

sjenning commented Apr 6, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rphillips, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2020
@rphillips
Copy link
Contributor Author

/test e2e-cmd

@rphillips rphillips changed the title Bug 1821341: UPSTREAM: 88440: Report deleted pod status correctly [release-4.3] Bug 1821341: UPSTREAM: 88440: Report deleted pod status correctly Apr 6, 2020
@derekwaynecarr derekwaynecarr added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 9, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 21a4b97 into openshift:release-4.3 Apr 10, 2020
@openshift-ci-robot
Copy link

@rphillips: All pull requests linked via external trackers have merged: openshift/origin#24841. Bugzilla bug 1821341 has been moved to the MODIFIED state.

In response to this:

[release-4.3] Bug 1821341: UPSTREAM: 88440: Report deleted pod status correctly

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mkumatag mkumatag mentioned this pull request Apr 14, 2020
Closed
4 tasks
@rphillips
Copy link
Contributor Author

/cherry-pick release-4.2

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 27, 2020
Closed
@openshift-cherrypick-robot
Copy link

@rphillips: new pull request created: #25036

In response to this:

/cherry-pick release-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rphillips rphillips mentioned this pull request May 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh Awaiting requested review from soltysh

@tbielawa tbielawa Awaiting requested review from tbielawa

Assignees

@sjenning sjenning

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@rphillips @openshift-ci-robot @sjenning @openshift-bot @openshift-cherrypick-robot @derekwaynecarr @openshift-merge-robot