Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1810470: UPSTREAM: <drop> Increase timeout in volume expansion test #24873

Merged
merged 1 commit into from
Apr 22, 2020
Merged

Bug 1810470: UPSTREAM: <drop> Increase timeout in volume expansion test #24873

merged 1 commit into from
Apr 22, 2020

Conversation

bertinatto
Copy link
Member

CC @openshift/storage

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 14, 2020
@openshift-ci-robot
Copy link

@bertinatto: This pull request references Bugzilla bug 1810470, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1810470: UPSTREAM: Increate timeout in volume expansion test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the vendor-update Touching vendor dir or related files label Apr 14, 2020
@bertinatto
Copy link
Member Author

/hold

for the e2e-aws-csi job.

If this works I'll submit upstream.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 14, 2020
@bertinatto bertinatto force-pushed the increate-timeout-volume-expansion-test branch from 92456c4 to e82f94f Compare April 14, 2020 10:18
jsafrane
jsafrane reviewed Apr 14, 2020
View reviewed changes
vendor/k8s.io/kubernetes/test/e2e/storage/testsuites/volume_expand.go Outdated
@@ -203,7 +203,15 @@ func (v *volumeExpandTestSuite) DefineTests(driver TestDriver, pattern testpatte
l.resource.Pvc = npvc

ginkgo.By("Creating a new pod with same volume")
l.pod2, err = e2epod.CreateSecPodWithNodeSelection(f.ClientSet, f.Namespace.Name, []*v1.PersistentVolumeClaim{l.resource.Pvc}, nil, false, "", false, false, e2epv.SELinuxLabel, nil, l.config.ClientNodeSelection, framework.PodStartTimeout)
newPodStartTimeout := framework.PodStartTimeout
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest PodStartAfterResizeTimeout and have it the same for all volume plugins / CSI drivers. Double the original PodStartTimeout?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@bertinatto bertinatto force-pushed the increate-timeout-volume-expansion-test branch 2 times, most recently from 57c331b to 67643bf Compare April 14, 2020 11:58
@bertinatto bertinatto force-pushed the increate-timeout-volume-expansion-test branch from 67643bf to 648d8f8 Compare April 14, 2020 12:02
@bertinatto bertinatto changed the title Bug 1810470: UPSTREAM: <drop> Increate timeout in volume expansion test Bug 1810470: UPSTREAM: <drop> Increase timeout in volume expansion test Apr 14, 2020
@bertinatto
Copy link
Member Author

/test e2e-gcp-upgrade

@bertinatto
Copy link
Member Author

/retest

2 similar comments
@bertinatto
Copy link
Member Author

/retest

@bertinatto
Copy link
Member Author

/retest

@jsafrane
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2020
@bertinatto
Copy link
Member Author

/assign @soltysh
for approval.

For context, we intend to test this in our CI for a few weeks [1] and submit the patch upstream if we find it solves the flake.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1824423

@jsafrane
Copy link
Contributor

/hold cancel
We really want it merged and get some CI coverage before we go upstream.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 16, 2020
soltysh
soltysh approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@bertinatto
Copy link
Member Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

13 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@smarterclayton smarterclayton removed the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2020
@smarterclayton
Copy link
Contributor

Tag this once master is passing again - retries not helping

@jsafrane
Copy link
Contributor

/retest
aws-serial looks green(ish)

@jsafrane
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, jsafrane, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link

@bertinatto: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/images 648d8f8 link /test images
ci/prow/e2e-aws-serial 648d8f8 link /test e2e-aws-serial

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 74769b8 into openshift:master Apr 22, 2020
@openshift-ci-robot
Copy link

@bertinatto: All pull requests linked via external trackers have merged: openshift/origin#24873. Bugzilla bug 1810470 has been moved to the MODIFIED state.

In response to this:

Bug 1810470: UPSTREAM: Increase timeout in volume expansion test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Aug 27, 2020
Merged
Merged
Merged
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Sep 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsafrane jsafrane jsafrane left review comments

@soltysh soltysh soltysh approved these changes

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@soltysh soltysh

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bertinatto @openshift-ci-robot @jsafrane @openshift-bot @smarterclayton @soltysh @openshift-merge-robot