Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove skipped tests that OVN now supports #24899

Merged
merged 1 commit into from May 1, 2020
Merged

Remove skipped tests that OVN now supports #24899

merged 1 commit into from May 1, 2020

Conversation

trozet
Copy link
Contributor

@trozet trozet commented Apr 20, 2020

Signed-off-by: Tim Rozet trozet@redhat.com

@trozet
Copy link
Contributor Author

trozet commented Apr 20, 2020

@dcbw PTAL

@trozet
Copy link
Contributor Author

trozet commented Apr 20, 2020

/test e2e-aws-ovn

@trozet trozet mentioned this pull request Apr 23, 2020
Closed
@dcbw
Copy link
Contributor

dcbw commented Apr 23, 2020

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2020
@smarterclayton
Copy link
Contributor

Rebase?

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 25, 2020
@trozet
Remove skipped tests that OVN now supports
a29383f 
Signed-off-by: Tim Rozet <trozet@redhat.com>
@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 29, 2020
@dcbw
Copy link
Contributor

dcbw commented Apr 29, 2020

/retest

@dcbw
Copy link
Contributor

dcbw commented Apr 29, 2020

Let's get openshift/release#8237 in, then trigger that job in this PR to make sure we can pass the now-un-skipped tests

@dcbw
Copy link
Contributor

dcbw commented Apr 30, 2020

/test e2e-aws-ovn

@dcbw
Copy link
Contributor

dcbw commented May 1, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 1, 2020
@dcbw
Copy link
Contributor

dcbw commented May 1, 2020

/retest

@smarterclayton can we get an OK on this one?

@smarterclayton
Copy link
Contributor

/approve

@smarterclayton smarterclayton added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 1, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, smarterclayton, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 1, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 6c88aa2 into openshift:master May 1, 2020
@openshift-merge-robot
Copy link
Contributor

This PR was merged in the time period when ci-operator was mistakenly reporting failed tests as passing.

If this repository has ci-operator jobs, please inspect their test results even if passing, and consider the need for fixing or even reverting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@dcbw dcbw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@trozet @dcbw @smarterclayton @openshift-ci-robot @openshift-bot @openshift-merge-robot