Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1829958: [release-4.4] Introduce IBMCloud provider, skip/fix tests #24937

Merged
merged 1 commit into from May 13, 2020
Merged

Bug 1829958: [release-4.4] Introduce IBMCloud provider, skip/fix tests #24937

merged 1 commit into from May 13, 2020

Conversation

csrwng
Copy link
Contributor

@csrwng csrwng commented Apr 30, 2020

Backport of #24817

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 30, 2020
@openshift-ci-robot
Copy link

@csrwng: This pull request references Bugzilla bug 1829958, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "4.4.z" instead
  • expected dependent Bugzilla bug 1827414 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.4] Bug 1829958: Introduce IBMCloud provider, skip/fix tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csrwng csrwng changed the title [release-4.4] Bug 1829958: Introduce IBMCloud provider, skip/fix tests Bug 1829958: [release-4.4] Introduce IBMCloud provider, skip/fix tests Apr 30, 2020
@csrwng
Copy link
Contributor Author

csrwng commented Apr 30, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link

@csrwng: This pull request references Bugzilla bug 1829958, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "4.4.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csrwng
Copy link
Contributor Author

csrwng commented May 4, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. labels May 4, 2020
@openshift-ci-robot
Copy link

@csrwng: This pull request references Bugzilla bug 1829958, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.4.z) matches configured target release for branch (4.4.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1827414 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1827414 targets the "4.5.0" release, which is one of the valid target releases: 4.5.0, 4.5.z
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 4, 2020
@csrwng
Copy link
Contributor Author

csrwng commented May 4, 2020

@derekwaynecarr ptal

@csrwng
Copy link
Contributor Author

csrwng commented May 4, 2020

/retest

1 similar comment
@csrwng
Copy link
Contributor Author

csrwng commented May 11, 2020

/retest

@csrwng
Copy link
Contributor Author

csrwng commented May 11, 2020

@derekwaynecarr bump

@derekwaynecarr
Copy link
Member

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, derekwaynecarr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 13, 2020
@sdodson
Copy link
Member

sdodson commented May 13, 2020

CI only, necessary for 4.3 backports.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit b7b453e into openshift:release-4.4 May 13, 2020
@openshift-ci-robot
Copy link

@csrwng: All pull requests linked via external trackers have merged: openshift/origin#24937. Bugzilla bug 1829958 has been moved to the MODIFIED state.

In response to this:

Bug 1829958: [release-4.4] Introduce IBMCloud provider, skip/fix tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulfantom paulfantom Awaiting requested review from paulfantom

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@derekwaynecarr derekwaynecarr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@csrwng @openshift-ci-robot @derekwaynecarr @openshift-bot @sdodson @openshift-merge-robot