Bug 1765301: UPSTREAM: 89379: deflake grace period for pod deletion in node e2e #25008
Conversation
giuseppe
force-pushed
the
deflake-grace-period
branch
from
025d59b
to
50e5b55
Compare
|
/retest |
|
@derekwaynecarr @mrunalp PTAL |
|
/retitle Bug 1765301: UPSTREAM: 89379: deflake grace period for pod deletion in node e2e |
openshift-ci-robot
changed the title
openshift-ci-robot
added
bugzilla/severity-high
|
@giuseppe: This pull request references Bugzilla bug 1765301, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
| @@ -54,7 +54,7 @@ var _ = SIGDescribe("Pods Extended", func() { | |||
| /* | |||
| Release : v1.15 | |||
| Testname: Pods, delete grace period | |||
| Description: Create a pod, make sure it is running. Using the http client send a 'delete' with gracePeriodSeconds=30. Pod SHOULD get deleted within 30 seconds. | |||
| Description: Create a pod, make sure it is running. Using the http client send a 'delete' with gracePeriodSeconds=30. Pod SHOULD get terminated within gracePeriodSeconds and removed from API server within a window. | |||
| */ | |||
| ginkgo.It("should be submitted and removed [Flaky]", func() { | |||
There was a problem hiding this comment.
in the upstream PR the [Flaky] is dropped
There was a problem hiding this comment.
thanks for the review. Restored now. I've added a new commit to regenerate the bindata so tests don't fail
Fixes: rhbz#1765301 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
deflake-grace-period
branch
from
50e5b55
to
618a01e
Compare
Signed-off-by: Giuseppe Scrivano <giuseppe@scrivano.org>
|
/test unit |
|
@sjenning tests are passing now |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, mrunalp, rphillips, sjenning The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@giuseppe: All pull requests linked via external trackers have merged: openshift/origin#25008. Bugzilla bug 1765301 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes: rhbz#1765301
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com