Bug 1840707: oVirt, skip network service tests #25012
Conversation
|
/assign @derekwaynecarr |
| `\[sig-network\] Networking Granular Checks: Services should function for endpoint-Service`, | ||
| `\[sig-network\] Networking Granular Checks: Services should function for node-Service`, | ||
| `\[sig-network\] Networking Granular Checks: Services should function for pod-Service`, | ||
| }, |
There was a problem hiding this comment.
i don't believe this does what you want. you need an actual change in the test to invoke skip when the ovirt platform is detected.
see that https://github.com/openshift/origin/pull/25012/files#diff-6ba77494282f6e840f44b01ce97335afR300 will not match this.
There was a problem hiding this comment.
I think that is the wrong URL
There was a problem hiding this comment.
it's right but github doesn't autoexpand for you.
line 300 of this file.
see also:
https://github.com/openshift/origin/blob/master/test/extended/oauth/requestheaders.go#L66-L68
as an example of how this is normally done.
There was a problem hiding this comment.
Looking at other PRs such as:
- https://github.com/openshift/origin/pull/24833/files
- https://github.com/openshift/origin/pull/24797/files
Are you sure I don't need to just edit zz_generated.annotations.go ?
There was a problem hiding this comment.
I am reasonably certain what you've done here will accomplish nothing other than adding a [Skipped:ovirt] prefix to the tests in question.
There was a problem hiding this comment.
I think that its what needs to be done, I looked into:
https://github.com/openshift/origin/blob/master/cmd/openshift-tests/provider.go#L57-L63
and it seems that the tests will be skipped if we have [Skipped:ovirt] in them.
Plus the tests come from kubernetes so I don't think we need to send a patch there:
https://github.com/kubernetes/kubernetes/blob/2fd8debe9b913f18b20a2269117409212391ef19/test/e2e/network/networking.go#L162
There was a problem hiding this comment.
Thanks, https://github.com/openshift/origin/blob/master/cmd/openshift-tests/provider.go#L57-L63 is the piece i was missing
There was a problem hiding this comment.
hack/update-generated-bindata.sh should update the other file for you
This PR skips the network service tests for ovirt. we didn't know the reason until recently and now there is a fix which is targeted for RHEL 8.3 [1] and there are openshift bugs for tracking the fix in openshift [2][3][4]. Since this is now a very known issue and is currently failing our CI and making it hard to distinguish between a red failed CI and a false one we decided to skip those test for ovirt until the fix will land. Tracker-Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1838751 [1] https://bugzilla.redhat.com/show_bug.cgi?id=1794714 [2] https://bugzilla.redhat.com/show_bug.cgi?id=1822714 [3] https://bugzilla.redhat.com/show_bug.cgi?id=1822755 [4] https://bugzilla.redhat.com/show_bug.cgi?id=1822766 Signed-off-by: Gal-Zaidman <gzaidman@redhat.com>
Gal-Zaidman
force-pushed
the
skip-network-tests
branch
from
6592b1c
to
b0aa6fb
Compare
|
/assign smarterclayton |
|
@squeed @danwinship one of you can probably approve this. There is a bug tracking that these tests need to be re-enabled on ovirt once the rhel issues are resolved. |
|
/retest |
|
/test e2e-gcp |
1 similar comment
|
/test e2e-gcp |
|
/lgtm |
I can confirm that it makes sense to disable those tests on oVirt until OCP has a kernel containing a fix for the vxlan offload bug, but I don't have |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, derekwaynecarr, Gal-Zaidman, squeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/bugzilla refresh |
|
@Gal-Zaidman: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retitle Bug 1840707: oVirt, skip network service tests |
openshift-ci-robot
changed the title
openshift-ci-robot
added
the
bugzilla/severity-unspecified
|
@Gal-Zaidman: This pull request references Bugzilla bug 1840707, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/invalid-bug
|
/bugzilla refresh |
openshift-ci-robot
removed
the
bugzilla/severity-unspecified
|
@Gal-Zaidman: This pull request references Bugzilla bug 1840707, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/severity-high
|
/bugzilla refresh |
|
@Gal-Zaidman: This pull request references Bugzilla bug 1840707, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@Gal-Zaidman: This pull request references Bugzilla bug 1840707, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
bugzilla/invalid-bug
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@Gal-Zaidman: All pull requests linked via external trackers have merged: openshift/origin#25012. Bugzilla bug 1840707 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release 4.4 |
|
/cherry-pick release-4.4 |
|
@Gal-Zaidman: cannot checkout release 4.4: error checking out release 4.4: exit status 1. output: error: pathspec 'release 4.4' did not match any file(s) known to git. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@Gal-Zaidman: #25012 failed to apply on top of branch "release-4.4": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is a clone of PR openshift#25012 For release 4.4 This PR skips the network service tests for ovirt. we didn't know the reason until recently and now there is a fix which is targeted for RHEL 8.3 [1] and there are openshift bugs for tracking the fix in openshift [2][3][4]. Since this is now a very known issue and is currently failing our CI and making it hard to distinguish between a red failed CI and a false one we decided to skip those test for ovirt until the fix will land. Tracker-Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1838751 [1] https://bugzilla.redhat.com/show_bug.cgi?id=1794714 [2] https://bugzilla.redhat.com/show_bug.cgi?id=1822714 [3] https://bugzilla.redhat.com/show_bug.cgi?id=1822755 [4] https://bugzilla.redhat.com/show_bug.cgi?id=1822766 Signed-off-by: Gal-Zaidman <gzaidman@redhat.com>
This PR skips the network service tests for ovirt.
we didn't know the reason until recently and now there is a fix which is targeted for RHEL 8.3 [1] and there are openshift bugs for tracking the fix in openshift [2][3][4].
Since this is now a very known issue and is currently failing our CI and making it hard to distinguish between a red failed CI and a false one we decided to skip those test for ovirt until the fix will land.
Tracker-Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1838751
[1] https://bugzilla.redhat.com/show_bug.cgi?id=1794714
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1822714
[3] https://bugzilla.redhat.com/show_bug.cgi?id=1822755
[4] https://bugzilla.redhat.com/show_bug.cgi?id=1822766
Signed-off-by: Gal-Zaidman gzaidman@redhat.com