Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable hyperkube build and switch to go modules #25224

Merged
merged 4 commits into from Jul 16, 2020
Merged

Disable hyperkube build and switch to go modules #25224

merged 4 commits into from Jul 16, 2020

Conversation

marun
Copy link
Contributor

@marun marun commented Jun 30, 2020 •
edited

TODO before merge of this PR

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. vendor-update Touching vendor dir or related files labels Jun 30, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 30, 2020
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 1, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 1, 2020
@marun marun changed the base branch from master to marun-testing July 1, 2020 22:32
@marun
Copy link
Contributor Author

marun commented Jul 2, 2020

/retest

4 similar comments
@marun
Copy link
Contributor Author

marun commented Jul 2, 2020

/retest

@marun
Copy link
Contributor Author

marun commented Jul 7, 2020

/retest

@marun
Copy link
Contributor Author

marun commented Jul 8, 2020

/retest

@marun
Copy link
Contributor Author

marun commented Jul 9, 2020

/retest

@marun
Copy link
Contributor Author

marun commented Jul 10, 2020

/retest

@marun
Copy link
Contributor Author

marun commented Jul 13, 2020

/retest

@marun
Copy link
Contributor Author

marun commented Jul 13, 2020

/test e2e-gcp-upgrade

@marun
Copy link
Contributor Author

marun commented Jul 14, 2020

/retest

2 similar comments
@marun
Copy link
Contributor Author

marun commented Jul 14, 2020

/retest

@marun
Copy link
Contributor Author

marun commented Jul 15, 2020

/retest

@deads2k
Copy link
Contributor

deads2k commented Jul 16, 2020

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2020
@marun marun changed the title WIP: Disable hyperkube build and switch to go modules Disable hyperkube build and switch to go modules Jul 16, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 16, 2020
@marun marun changed the base branch from marun-testing to master July 16, 2020 18:33
@deads2k
Copy link
Contributor

deads2k commented Jul 16, 2020

/lgtm

code-slayer achievement unlocked. I think -18M may be a record

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, marun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k
Copy link
Contributor

deads2k commented Jul 16, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@alvaroaleman
Copy link
Contributor

/test unit

@openshift-ci-robot
Copy link

@alvaroaleman: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test artifacts
  • /test e2e-aws-csi
  • /test e2e-aws-disruptive
  • /test e2e-aws-fips
  • /test e2e-aws-image-registry
  • /test e2e-aws-jenkins
  • /test e2e-aws-multitenant
  • /test e2e-aws-ovn
  • /test e2e-aws-serial
  • /test e2e-azure
  • /test e2e-cmd
  • /test e2e-gcp
  • /test e2e-gcp-builds
  • /test e2e-gcp-image-ecosystem
  • /test e2e-gcp-upgrade
  • /test e2e-vsphere
  • /test images
  • /test verify
  • /test verify-deps
  • /test extended_gssapi
  • /test extended_ldap_groups
  • /test extended_networking

Use /test all to run the following jobs:

  • pull-ci-openshift-origin-master-artifacts
  • pull-ci-openshift-origin-master-e2e-aws-csi
  • pull-ci-openshift-origin-master-e2e-aws-fips
  • pull-ci-openshift-origin-master-e2e-aws-serial
  • pull-ci-openshift-origin-master-e2e-cmd
  • pull-ci-openshift-origin-master-e2e-gcp
  • pull-ci-openshift-origin-master-e2e-gcp-upgrade
  • pull-ci-openshift-origin-master-images
  • pull-ci-openshift-origin-master-verify
  • pull-ci-openshift-origin-master-verify-deps

In response to this:

/test unit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 16, 2020 •
edited

@marun: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/unit 59c893f link /test unit
ci/prow/e2e-vsphere 2822e80 link /test e2e-vsphere
ci/prow/e2e-aws-disruptive 2822e80 link /test e2e-aws-disruptive
ci/prow/artifacts 2c63ffa link /test artifacts

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@marun marun mentioned this pull request Jul 16, 2020
Merged
@openshift-merge-robot openshift-merge-robot merged commit 4c7139f into openshift:master Jul 16, 2020
@marun marun deleted the switch-to-go-modules branch July 16, 2020 22:46
@soltysh soltysh mentioned this pull request Jul 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@marun @deads2k @openshift-ci-robot @openshift-bot @alvaroaleman @openshift-merge-robot