Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1883345: [release-4.5] Re-enable skipped conformance tests for IBM Cloud #25520

Merged
merged 1 commit into from Oct 24, 2020
Merged

Bug 1883345: [release-4.5] Re-enable skipped conformance tests for IBM Cloud #25520

merged 1 commit into from Oct 24, 2020

Conversation

jmcmeek
Copy link
Contributor

@jmcmeek jmcmeek commented Sep 17, 2020

Cherry-pick of #25220

Re-enabling selected tests now that associated bugs have been fixed and are in the Red Hat OpenShift on IBM Cloud v4.3 builds.

[Feature:Prometheus][Conformance] Prometheus when installed on the cluster should provide ingress metrics
[Conformance][Area:Networking][Feature:Router] The HAProxy router should enable openshift-monitoring to pull metrics
[k8s.io] [sig-node] Pods Extended [k8s.io] Pod Container Status should never report success for a pending container

@jmcmeek
[release-4.5] Re-enable skipped conformance tests for IBM Cloud
bfc231b 
Cherry-pick of openshift#25220

Re-enabling selected tests now that associated bugs have been fixed and are in the Red Hat OpenShift on IBM Cloud v4.3 builds.
```
[Feature:Prometheus][Conformance] Prometheus when installed on the cluster should provide ingress metrics
[Conformance][Area:Networking][Feature:Router] The HAProxy router should enable openshift-monitoring to pull metrics
[k8s.io] [sig-node] Pods Extended [k8s.io] Pod Container Status should never report success for a pending container
```
@openshift-ci-robot
Copy link

@jmcmeek: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.5] Re-enable skipped conformance tests for IBM Cloud

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmcmeek
Copy link
Contributor Author

jmcmeek commented Sep 18, 2020

@csrwng FYI. Got back to work on cherry-picking this. Hope I did it right.

rtheis
rtheis approved these changes Sep 18, 2020
View reviewed changes
Copy link

@rtheis rtheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link

@rtheis: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csrwng
Copy link
Contributor

csrwng commented Sep 28, 2020

/retitle: Bug 1883345: [release-4.5] Re-enable skipped conformance tests for IBM Cloud

@openshift-ci-robot openshift-ci-robot changed the title [release-4.5] Re-enable skipped conformance tests for IBM Cloud : Bug 1883345: [release-4.5] Re-enable skipped conformance tests for IBM Cloud Sep 28, 2020
@openshift-ci-robot
Copy link

@jmcmeek: This pull request references Bugzilla bug 1883345, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.z) matches configured target release for branch (4.5.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1883343 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1883343 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

In response to this:

: Bug 1883345: [release-4.5] Re-enable skipped conformance tests for IBM Cloud

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 28, 2020
@csrwng
Copy link
Contributor

csrwng commented Sep 28, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2020
@csrwng
Copy link
Contributor

csrwng commented Sep 28, 2020

/test e2e-aws-serial

@csrwng
Copy link
Contributor

csrwng commented Sep 28, 2020

@derekwaynecarr ptal

@csrwng
Copy link
Contributor

csrwng commented Sep 28, 2020

/retitle Bug 1883345: [release-4.5] Re-enable skipped conformance tests for IBM Cloud

@openshift-ci-robot openshift-ci-robot changed the title : Bug 1883345: [release-4.5] Re-enable skipped conformance tests for IBM Cloud Bug 1883345: [release-4.5] Re-enable skipped conformance tests for IBM Cloud Sep 28, 2020
@csrwng
Copy link
Contributor

csrwng commented Sep 28, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. and removed bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. labels Sep 28, 2020
@openshift-ci-robot
Copy link

@csrwng: This pull request references Bugzilla bug 1883345, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.z) matches configured target release for branch (4.5.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1883343 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1883343 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@derekwaynecarr
Copy link
Member

/approve
/lgtm

@csrwng
Copy link
Contributor

csrwng commented Oct 13, 2020

/retest

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, derekwaynecarr, jmcmeek, rtheis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2020
@sjenning sjenning removed their request for review October 21, 2020 02:36
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@bparees bparees added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 23, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 494e8c6 into openshift:release-4.5 Oct 24, 2020
@openshift-ci-robot
Copy link

@jmcmeek: All pull requests linked via external trackers have merged:

Bugzilla bug 1883345 has been moved to the MODIFIED state.

In response to this:

Bug 1883345: [release-4.5] Re-enable skipped conformance tests for IBM Cloud

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtheis rtheis rtheis approved these changes

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@csrwng csrwng

@derekwaynecarr derekwaynecarr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@jmcmeek @openshift-ci-robot @csrwng @derekwaynecarr @openshift-bot @rtheis @bparees @openshift-merge-robot