Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/extended/prometheus: add test validating alert severity #26016

Closed
wants to merge 1 commit into from
Closed

test/extended/prometheus: add test validating alert severity #26016

wants to merge 1 commit into from

Conversation

simonpasquier
Copy link
Contributor

@simonpasquier simonpasquier commented Mar 25, 2021 •
edited

In the context of openshift/enhancements#637, this change adds a test that ensures all alerting rules shipped by core components follow the established standards. In particular, all alerting rules must have a severity label and the value should be either info, warning or critical (the Watchdog alert is the only exception).

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 25, 2021
paulfantom
paulfantom approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@paulfantom paulfantom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: paulfantom, simonpasquier
To complete the pull request process, please assign smarterclayton after the PR has been reviewed.
You can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2021
@simonpasquier simonpasquier force-pushed the check-alert-severity branch 4 times, most recently from 7674ef9 to f9b993e Compare March 26, 2021 16:03
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 29, 2021
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 8, 2021
@simonpasquier simonpasquier changed the title [WIP]test/extended/prometheus: add test validating alert severity test/extended/prometheus: add test validating alert severity May 6, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 6, 2021
@simonpasquier
Copy link
Contributor Author

/test e2e-metal-ipi-ovn-ipv6

2 similar comments
@simonpasquier
Copy link
Contributor Author

/test e2e-metal-ipi-ovn-ipv6

@simonpasquier
Copy link
Contributor Author

/test e2e-metal-ipi-ovn-ipv6

@simonpasquier simonpasquier force-pushed the check-alert-severity branch 2 times, most recently from 881fb47 to c28b8da Compare May 10, 2021 12:15
@paulfantom
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 10, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: paulfantom, simonpasquier
To complete the pull request process, please assign smarterclayton after the PR has been reviewed.
You can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@simonpasquier
Copy link
Contributor Author

/retest

@simonpasquier
test/extended/prometheus: validate alert severities
77a50e2 
As per the "Alerting Consistency" enhancement, alerts should have a
`severity` label and this label should be one of "critical", "warning"
or "info". This change adds a test verifying that all alerting rules
shipped as part of OpenShift comply with this requirement.

[1] https://github.com/openshift/enhancements/blob/master/enhancements/monitoring/alerting-consistency.md

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
@simonpasquier
Copy link
Contributor Author

/retest

@simonpasquier
Copy link
Contributor Author

/test e2e-aws-serial

2 similar comments
@simonpasquier
Copy link
Contributor Author

/test e2e-aws-serial

@simonpasquier
Copy link
Contributor Author

/test e2e-aws-serial

@simonpasquier
Copy link
Contributor Author

@smarterclayton can you have another look please? The test should report all alerting rules that don't have a severity label or define a severity value other than info, warning or critical.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 25, 2021

@simonpasquier: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-builds 77a50e2 link /test e2e-gcp-builds
ci/prow/e2e-aws-disruptive 77a50e2 link /test e2e-aws-disruptive
ci/prow/e2e-gcp-disruptive 77a50e2 link /test e2e-gcp-disruptive
ci/prow/e2e-aws-jenkins 77a50e2 link /test e2e-aws-jenkins

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@simonpasquier
Copy link
Contributor Author

@smarterclayton friendly ping

@simonpasquier
Copy link
Contributor Author

/assign @derekwaynecarr

@bison bison mentioned this pull request Sep 23, 2021
Merged
@bison
Copy link

bison commented Sep 23, 2021

/close

Closing this (if I can) in favor of #26476.

@openshift-ci openshift-ci bot closed this Sep 23, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 23, 2021

@bison: Closed this PR.

In response to this:

/close

Closing this (if I can) in favor of #26476.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarterclayton smarterclayton smarterclayton left review comments

@paulfantom paulfantom paulfantom approved these changes

@s-urbaniak s-urbaniak Awaiting requested review from s-urbaniak

Assignees

@paulfantom paulfantom

@derekwaynecarr derekwaynecarr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@simonpasquier @openshift-ci-robot @paulfantom @bison @smarterclayton @derekwaynecarr