Ignore upgradable false condition on TechPreview clusters #26349
Conversation
JoelSpeed
force-pushed
the
ignore-kas-condition-tpnu
branch
from
ff1d9b8
to
e25520b
Compare
|
I have now tested this on a cluster and it is working as expected |
|
/retest |
| // kube-apiserver blocks upgrades when feature gates are present. | ||
| // Allow testing of TechPreviewNoUpgrade clusters by ignoring this condition. | ||
| if isTechPreview && name == "kube-apiserver" && isKubeAPIUpgradableTechPreviewCondition(worstCondition) { | ||
| continue |
There was a problem hiding this comment.
Does this risk ignoring other failure conditions?
There was a problem hiding this comment.
This may depend on what surprisingConditions returns. I would expect this condition to be relatively low down the list of bad conditions, but it's something I need to check.
If my assumption that this isn't a terrible condition is correct, then another failure should take precedence in assignment of worstCondition and we should be safe.
There was a problem hiding this comment.
Confirmed, Upgradable is the last one it looks for when it's searching the conditions, this should be safe as is, if the available or degraded conditions are not as expected they will take precedence
|
/lgtm |
|
/assign @njhale |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed, mdbooth, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
smarterclayton
added
the
bugzilla/valid-bug
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
While trying to set up CI testing for clusters with a
TechPreviewNoUpgradefeature gate, this test fails as Kube API server blocks upgrades for tech preview clusters.This PR adds an exception so that if a cluster has a
TechPreviewNoUpgradefeature set enabled, and the appropriate condition, this will no longer prevent the test from passing.Specifically it prevents this error:
Ref: openshift/release#19845