Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group admin cmds #3557

Merged
merged 1 commit into from
Jul 14, 2015
Merged

Group admin cmds #3557

merged 1 commit into from
Jul 14, 2015

Conversation

pravisankar
Copy link

  • Group commands in oadm for ease of use
  • Group oadm certificate related cmds under 'oadm ca'

closes #3424 , #2461

@pravisankar
Copy link
Author

@liggitt @smarterclayton PTAL

@liggitt
Copy link
Contributor

liggitt commented Jul 2, 2015

I would keep the more descriptive names (create-master-certs vs master). Can we leave the old commands functional but deprecated and unsurfaced in the list of command groups?

@liggitt liggitt self-assigned this Jul 3, 2015
@pravisankar
Copy link
Author

[test]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/3617/)

@pravisankar
Copy link
Author

@liggitt updated, ptal

liggitt
liggitt reviewed Jul 10, 2015
View reviewed changes
hack/test-cmd.sh
@@ -283,6 +283,9 @@ echo "templates: ok"
[ "$(openshift kubectl 2>&1 | grep 'Kubernetes cluster')" ]
[ "$(oadm 2>&1 | grep 'OpenShift Administrative Commands')" ]
[ "$(openshift admin 2>&1 | grep 'OpenShift Administrative Commands')" ]
[ "$(oadm | grep 'Basic Commands:')" ]
[ "$(oadm | grep 'Install Commands:')" ]
[ "$(oadm ca | grep 'Manage certificates')" ]
[ "$(openshift start kubernetes 2>&1 | grep 'Kubernetes server components')" ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a group of test invocations to make sure the old commands still exist. Just invoke --help on them and grep for an expected help string for openshift admin create-master-certs, etc

@pravisankar
Copy link
Author

@liggitt added deprecated cmd checks in hack/test-cmd.sh, please review/merge

@liggitt
Copy link
Contributor

liggitt commented Jul 12, 2015

LGTM. Squash?

Group commands in oadm for ease of use
bee9eda 
Group oadm certificate related cmds under 'oadm ca'

To maintain backward compatibility, old commands still work
with deprecated message but are not surfaced in the help message.
@pravisankar
Copy link
Author

[merge]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/2722/) (Image: devenv-fedora_1988)

@pravisankar pravisankar mentioned this pull request Jul 13, 2015
Closed
@pravisankar
Copy link
Author

re[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin up to bee9eda

openshift-bot pushed a commit that referenced this pull request Jul 14, 2015
Merge pull request #3557 from pravisankar/group-admin-cmds
68ee52f 
Merged by openshift-bot
@openshift-bot openshift-bot merged commit 68ee52f into openshift:master Jul 14, 2015
@adellape adellape mentioned this pull request Aug 12, 2015
Closed
@nak3 nak3 mentioned this pull request Sep 17, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@liggitt liggitt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Group admin cmds similar to oc cmds
5 participants
@pravisankar @liggitt @openshift-bot @fabianofranz @deads2k