UPSTREAM: fix ldapserver test panic #4168
Conversation
|
Is there multithreaded access to that close? |
|
calling twice will still cause problems. this is just fixing the case where no one was interested in a callback, and Abandon called close on a nil channel anyway. this is only used in the integration test, I have a TODO to revisit |
|
Is this WIP for a reason? |
|
was going to see if I could get a quick merge upstream to avoid breaking godeps |
liggitt
changed the title
|
[test] |
|
@smarterclayton no movement upstream, this is fine to merge now. not sure what to do with godeps to help prevent stompage of patches on less-scrutinized vendered packages |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/4186/) |
|
Evaluated for origin test up to de466c4 |
|
Other than a test case that validates it, not much. Better process around rebase. |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/2995/) (Image: devenv-fedora_2173) |
|
Evaluated for origin merge up to de466c4 |
Merged by openshift-bot
|
@liggitt this was accepted upstream, should we bump and remove this patch? |
|
sure |
Upstream PR: vjeantet/ldapserver#15
Fixes #4066