Bug 1247680 - must not truncate svc names in the cli, rely on API validation

[fabianofranz]

Bug 1251601 and 1247680.

This will now display the error message from the API instead of silently truncating and lowercasing the provided names:

The Service "aaaaabbbbbcccccdddddeeeee" is invalid.

* metadata.name: invalid value 'aaaaabbbbbcccccdddddeeeee', Details: must be a DNS 952 label (at most 24 characters, matching regex [a-z]([-a-z0-9]*[a-z0-9])?): e.g. "my-name"

[fabianofranz]

@jwforres ptal

[jwforres]

worth adding a testcase for? otherwise LGTM

[fabianofranz]

[merge]

[openshift-bot]

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/3005/) (Image: devenv-fedora_2173)

[openshift-bot]

Evaluated for origin merge up to f94c655

[openshift-bot]

[Test]ing while waiting on the merge queue

[openshift-bot]

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/4212/)

[openshift-bot]

Evaluated for origin test up to f94c655

[liggitt]

people who comment on pull requests post-merge are the worst. also, will a name longer than 24 characters leave a bunch of partially created resources when it fails on services?

[liggitt]

@smarterclayton comment on what you want for bug 1251601 and 1247680.

[smarterclayton]

Danger, this is not safe. We have to restrict --name, but this is the
service name which we infer from another input (like the git repo).

So this needs to be reverted - we need to validate

• that --name fits the minimum bar for a valid value
• that anything we infer from a Git repo name or Image name is of the
  proper lengths.

So we have to truncate this in the CLI.

On Tue, Aug 18, 2015 at 4:39 PM, Jordan Liggitt notifications@github.com
wrote:

@smarterclayton https://github.com/smarterclayton comment on what you
want for bug 1251601 and 1247680.

—
Reply to this email directly or view it on GitHub
#4220 (comment).

Clayton Coleman | Lead Engineer, OpenShift

[liggitt]

and lowercase?

[fabianofranz]

@liggitt hrm, I'm afraid so, you are correct.

[jwforres]

It also has to start with a letter, see
https://bugzilla.redhat.com/show_bug.cgi?id=1251845

On Tue, Aug 18, 2015 at 4:42 PM, Jordan Liggitt notifications@github.com
wrote:

and lowercase?

—
Reply to this email directly or view it on GitHub
#4220 (comment).

[jwforres]

FYI, fix for the console #4249

[fabianofranz]

So we are replicating the validation that happens in the API on every client? Shouldn't we rely on the API for validation, but have it fail on (some) errors, like validation?

[fabianofranz]

Reverted and properly fixed for --name in #4251.