Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add v1beta3 removal notes to UPGRADE.md #5282

Merged
merged 1 commit into from
Oct 23, 2015
Merged

Add v1beta3 removal notes to UPGRADE.md #5282

merged 1 commit into from
Oct 23, 2015

Conversation

ironcladlou
Copy link
Contributor

Closes #5232

@ironcladlou
Copy link
Contributor Author

cc @deads2k @liggitt @smarterclayton

deads2k
deads2k reviewed Oct 21, 2015
View reviewed changes
UPGRADE.md
references:

1. The `etcdStorageConfig.openShiftStorageVersion` field value should be `v1`.
1. The `apiLevels` field should contain only `v1`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the kube apilevels

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added notes for the kube field, thanks!

@deads2k
Copy link
Contributor

deads2k commented Oct 21, 2015

Minor update. lgtm otherwise.

@sdodson This should probably make it into release notes.
@jwforres Did the webconsole ever support an HA mode of any kind? This could produce some weird results. With multiple API servers, sometimes you'd get a valid response and sometimes you wouldn't.

@smarterclayton different v1 apis are different. In a rolling update, old masters that read and then write may remove fields that new masters have allowed. Do we have any way to keep that from happening?

@liggitt
Copy link
Contributor

liggitt commented Oct 22, 2015

Note about oc clients <= 1.0.4 needing to pass --api-version=v1?

@ironcladlou ironcladlou force-pushed the v1beta3-upgrade-notes branch 2 times, most recently from bb1f5f0 to b1cb14a Compare October 22, 2015 17:32
@ironcladlou
Copy link
Contributor Author

Note about oc clients <= 1.0.4 needing to pass --api-version=v1?

Done.

@deads2k
Copy link
Contributor

deads2k commented Oct 22, 2015

[merge]

liggitt
liggitt reviewed Oct 22, 2015
View reviewed changes
UPGRADE.md
OpenShift master configuration files will need updated to remove `v1beta3`
references:

1. The `etcdStorageConfig.openShiftStorageVersion` field value should be `v1`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need etcdStorageConfig.kubernetesStorageVersion set to v1 also

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/3738/) (Image: devenv-rhel7_2533)

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/6081/)

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to d6836c4

@sdodson sdodson mentioned this pull request Oct 22, 2015
Closed
@openshift-bot openshift-bot removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 22, 2015
@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to d6836c4

openshift-bot pushed a commit that referenced this pull request Oct 23, 2015
Merge pull request #5282 from ironcladlou/v1beta3-upgrade-notes
d85efd7 
Merged by openshift-bot
@openshift-bot openshift-bot merged commit d85efd7 into openshift:master Oct 23, 2015
@ironcladlou ironcladlou deleted the v1beta3-upgrade-notes branch October 23, 2015 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ironcladlou @deads2k @liggitt @openshift-bot