Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix namespace initialization #5596

Merged
merged 1 commit into from
Nov 3, 2015
Merged

Fix namespace initialization #5596

merged 1 commit into from
Nov 3, 2015

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Nov 2, 2015

Fixes #5587

liggitt
liggitt reviewed Nov 2, 2015
View reviewed changes
pkg/cmd/server/origin/ensure.go
_, err = c.KubeClient().Namespaces().Create(namespace)
if err != nil {
glog.Errorf("Error creating namespace: %v due to %v\n", namespace, err)
namespace, createErr := c.KubeClient().Namespaces().Create(&kapi.Namespace{ObjectMeta: kapi.ObjectMeta{Name: c.Options.PolicyConfig.OpenShiftSharedResourcesNamespace}})
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we needed to pass the created namespace to ensureNamespaceServiceAccountRoleBindings or the namespace annotation update would fail with a missing resource version

@liggitt
Copy link
Contributor Author

liggitt commented Nov 2, 2015

@smarterclayton PTAL

@smarterclayton
Copy link
Contributor

LGTM but want one more set of eyes

@liggitt
Copy link
Contributor Author

liggitt commented Nov 2, 2015

@pweil- or @deads2k have good sets of eyes. one of them (or one eye each) should do

@deads2k
Copy link
Contributor

deads2k commented Nov 2, 2015

You know that I'd want these set up with parallel structure.

@deads2k
Copy link
Contributor

deads2k commented Nov 2, 2015

lgtm

@deads2k
Copy link
Contributor

deads2k commented Nov 2, 2015

This structure on the refactor list overall to make it easier to deal with new service accounts, right?

@smarterclayton smarterclayton added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2015
@smarterclayton
Copy link
Contributor

[merge]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/3910/) (Image: devenv-rhel7_2630)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 6223100

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 6223100

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/6650/)

openshift-bot pushed a commit that referenced this pull request Nov 3, 2015
Merge pull request #5596 from liggitt/default_namespace_roles
be5801c 
Merged by openshift-bot
@openshift-bot openshift-bot merged commit be5801c into openshift:master Nov 3, 2015
@liggitt liggitt deleted the default_namespace_roles branch November 3, 2015 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liggitt @smarterclayton @deads2k @openshift-bot