UPSTREAM: 21005: Use a different verb for delete collection #7209
Conversation
|
[test] |
|
@liggitt you going to plumb this through to our roles? |
|
hadn't decided yet... do we want project admins having this or do we want to limit it to things like the namespace controller for now? |
Yeah, if you can list and you can delete, you should be able to deletecollection. I just don't want to write equivalence logic. |
|
updated bootstrap policy |
| @@ -115,7 +115,7 @@ func init() { | |||
| // BuildDeleteController.PodManager (ControllerClient) | |||
| // BuildControllerFactory.buildDeleteLW | |||
| { | |||
| Verbs: sets.NewString("get", "list", "create", "delete"), | |||
| Verbs: sets.NewString("get", "list", "create", "delete", "deletecollection"), | |||
There was a problem hiding this comment.
These don't actually use these powers yet, right? Seems like we'd keep the list tight and make them update it when they use it.
There was a problem hiding this comment.
sure, removed from sa roles
|
comment addressed, tag but hold for rebase |
|
lgtm |
|
[merge] |
|
Evaluated for origin test up to a685817 |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/1280/) |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/5024/) (Image: devenv-rhel7_3473) |
|
copr error, [merge] |
|
Evaluated for origin merge up to a685817 |
Merged by openshift-bot
Related to #7172
Merged upstream, holding for rebase
@deads2k @derekwaynecarr