Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review deletecollection changes for origin #7172

Closed
2 of 4 tasks
liggitt opened this issue Feb 10, 2016 · 8 comments
Closed
2 of 4 tasks

Review deletecollection changes for origin #7172

liggitt opened this issue Feb 10, 2016 · 8 comments
Assignees
Labels
area/security component/restapi lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/P2

Comments

@liggitt
Copy link
Contributor

liggitt commented Feb 10, 2016

Added upstream in https://github.com/kubernetes/kubernetes/pull/18290/files#diff-7cf62556f9392a93c45627f77bff3229R450

cc @deads2k

@deads2k
Copy link
Contributor

deads2k commented Feb 10, 2016

Looks like it will be an additional verb upstream in the query handler and then changes to policy. You want it or shall I?

@liggitt
Copy link
Contributor Author

liggitt commented Feb 10, 2016

Actually, I don't see a new verb upstream in GetRequestInfo... I think it just looks like a delete without a resource name

@deads2k
Copy link
Contributor

deads2k commented Feb 10, 2016

I glanced and saw this: https://github.com/openshift/origin/blob/master/Godeps/_workspace/src/k8s.io/kubernetes/pkg/apiserver/api_installer.go#L598, which looks like a new verb, but I haven't drilled into it.

@deads2k
Copy link
Contributor

deads2k commented Feb 10, 2016

Ah, I see. Virtual verb wired into the same action on the route. Awesome. I don't know that I care about restricting it separately.

@liggitt
Copy link
Contributor Author

liggitt commented Feb 23, 2016

policy changes are complete, lowering priority for remaining items

@liggitt liggitt mentioned this issue Mar 16, 2016
27 tasks
@smarterclayton smarterclayton modified the milestones: 1.2.0, 1.2.x, 1.3.0 Jul 12, 2016
@liggitt liggitt modified the milestones: 1.3.0, 1.4.0 Sep 1, 2016
@smarterclayton smarterclayton modified the milestones: 1.4.0, 1.5.0 Jan 31, 2017
@smarterclayton smarterclayton modified the milestones: 1.5.0, 1.6.0 Mar 12, 2017
@liggitt liggitt modified the milestone: 3.6.0 Jun 14, 2017
@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 12, 2018
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 15, 2018
@openshift-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/security component/restapi lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/P2
Projects
None yet
Development

No branches or pull requests

5 participants