Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: 21095: Provide current namespace to InClusterConfig #7301

Merged
merged 2 commits into from
Feb 18, 2016
Merged

UPSTREAM: 21095: Provide current namespace to InClusterConfig #7301

merged 2 commits into from
Feb 18, 2016

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Feb 15, 2016

Makes in-cluster-config work without any extra pod modifications

Holding for rebase

@liggitt
Copy link
Contributor Author

liggitt commented Feb 15, 2016

[test]

@liggitt
Copy link
Contributor Author

liggitt commented Feb 16, 2016

@smarterclayton for review of POD_NAMESPACE-related changes in origin. Hold on merge, since it has an UPSTREAM commit

@liggitt
Copy link
Contributor Author

liggitt commented Feb 16, 2016

flake #7243 - [test]

@smarterclayton
Copy link
Contributor

LGTM, merge when reopen

@liggitt liggitt added this to the 1.2.0 milestone Feb 16, 2016
@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/1302/) (Image: devenv-rhel7_3466)

@liggitt liggitt added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2016
@smarterclayton
Copy link
Contributor

[test]

On Wed, Feb 17, 2016 at 4:05 PM, OpenShift Bot notifications@github.com
wrote:

continuous-integration/openshift-jenkins/test FAILURE (
https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/1279/)

—
Reply to this email directly or view it on GitHub
#7301 (comment).

@liggitt
Copy link
Contributor Author

liggitt commented Feb 17, 2016

Doesn't look like a flake, I'll dig into the test failures

@liggitt
Copy link
Contributor Author

liggitt commented Feb 18, 2016

s/testclient.Action/core.Action/ after rebase landed. clean pick from upstream now. [merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 9de6c71

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/1302/)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 9de6c71

openshift-bot pushed a commit that referenced this pull request Feb 18, 2016
Merge pull request #7301 from liggitt/in-cluster-namespace
16b14b1 
Merged by openshift-bot
@openshift-bot openshift-bot merged commit 16b14b1 into openshift:master Feb 18, 2016
@liggitt liggitt deleted the in-cluster-namespace branch February 19, 2016 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@liggitt @smarterclayton @openshift-bot