vendor quickstart templates into origin #7436
Conversation
|
@smarterclayton @csrwng ptal. I am not loving this mechanism for automatically parsing the readme and pulling down the files, but it could be worse... open to reasonable suggestions for improvement. Creating a directory for each one makes the scripting much more complicated. |
| pushd examples/quickstarts | ||
| rm *json | ||
| rm *yaml | ||
| curl `grep https://raw.githubusercontent.com README.md | sed -E "s/.*\((.*)\) -.*/\\1 -O/"` |
There was a problem hiding this comment.
Will this work on Mac?
|
I'm ok with it not creating directories. |
|
LGTM, add a section to HACKING.md to describe it. |
|
And comments in the script. |
|
@smarterclayton updated. |
|
LGTM [merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/5026/) (Image: devenv-rhel7_3474) |
|
Evaluated for origin merge up to df353fc |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin test up to df353fc |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/1354/) |
Merged by openshift-bot
No description provided.