Fix problem with replicationController ops in kube command #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You are behind Michal in the queue and I think he's going to break you |
|
@smarterclayton I will remain ever-vigilant |
|
You hath been broken |
|
LGTM [merge] |
|
Origin Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/90/) (Image: devenv-fedora_157) |
|
Evaluated for origin up to e516ee1 |
openshift-bot
pushed a commit
that referenced
this pull request
Sep 12, 2014
Merged by openshift-bot
ironcladlou
pushed a commit
to ironcladlou/origin
that referenced
this pull request
Oct 14, 2014
Add more deployment unit tests
danwinship
pushed a commit
to danwinship/origin
that referenced
this pull request
Jun 24, 2016
lockwrap shell utils; add support for internet connectivity to docker containers
soltysh
pushed a commit
to soltysh/origin
that referenced
this pull request
Apr 19, 2017
…ultStorageFactory NewDefaultStorageFactory and ClientCARegistrationHook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you try to do 'openshift kube resize 2', the command will fail because the executeAPIRequest method assumes that the first argument is of the form '/'. The fix is to run the executeControllerRequest method first which will simply return false and fall through to executeAPIRequest.