Update glogging to always set level, and to respect glog.level #8924

smarterclayton · 2016-05-18T15:51:39Z

Fixes #8903 partially

smarterclayton · 2016-05-18T17:50:59Z

[testonlyextended][extended:core(should allow to change build log level)]

smarterclayton · 2016-05-18T17:51:02Z

[test]

smarterclayton · 2016-05-18T18:52:35Z

@bparees @gabemontero fixes the failing extended test

gabemontero · 2016-05-18T19:41:27Z

@smarterclayton @bparees I'll check the origin_extended_build_test job once this merges

smarterclayton · 2016-05-18T19:43:08Z

Need a sign off

bparees · 2016-05-18T21:30:39Z

pkg/build/builder/sti.go

 		}
-		glog.Infof("Pushing %s image ...", pushTag)
+		glog.V(0).Infof("Pushing %s image ...", pushTag)


Printed at 0 because it's the slowest part of the operation, so always shown.

Isn't 1 already always shown? I was under the impression we were using 0 for warning/erring, and 1 for basic info (still always shown by default).

Anything we would always show would be zero. I suppose we could argue you might only want to see errors in some cases, but we don't set that up yet.

bparees · 2016-05-22T17:59:15Z

pkg/build/builder/docker.go

@@ -116,11 +116,11 @@ func (d *DockerBuilder) Build() error {
 		if authPresent {
 			glog.V(4).Infof("Authenticating Docker push with user %q", pushAuthConfig.Username)
 		}
-		glog.Infof("Pushing image %s ...", pushTag)
+		glog.V(1).Infof("Pushing image %s ...", pushTag)


well you've got this push as a v(1) and the other push as a v(0)

smarterclayton · 2016-05-23T16:17:57Z

[test]

On Mon, May 23, 2016 at 12:00 PM, OpenShift Bot notifications@github.com
wrote:

continuous-integration/openshift-jenkins/test FAILURE (
https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/3970/)

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#8924 (comment)

openshift-bot · 2016-05-23T18:00:49Z

Evaluated for origin testonlyextended up to 1b10493

openshift-bot · 2016-05-23T18:30:53Z

continuous-integration/openshift-jenkins/testonlyextended SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin_extended/189/) (Extended Tests: core(should allow to change build log level))

smarterclayton · 2016-05-23T19:41:33Z

Wtf is this:


service "database" created
You have exposed your service on an external port on all nodes in your
cluster.  If you want to expose this service to the external internet, you may
need to set up firewall rules for the service port(s) (tcp:31000) to
serve traffic.

See http://releases.k8s.io/HEAD/docs/user-guide/services-firewalls.md
for more details.
service "database-external" created

On Mon, May 23, 2016 at 3:19 PM, OpenShift Bot notifications@github.com
wrote:

continuous-integration/openshift-jenkins/test FAILURE (
https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/3984/)

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#8924 (comment)

smarterclayton · 2016-05-23T19:42:03Z

@Kargakis this does not belong here.

smarterclayton · 2016-05-23T19:42:35Z

I'd like this patched out.

smarterclayton · 2016-05-23T19:58:37Z

[test]

openshift-bot · 2016-05-23T20:01:04Z

Evaluated for origin test up to 1b10493

openshift-bot · 2016-05-23T21:08:50Z

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/3993/)

0xmichalis · 2016-05-24T08:58:35Z

I'd like this patched out.

I think we can have it in the factory so we won't need to carry a patch.

smarterclayton · 2016-05-24T13:43:14Z

@Kargakis thanks.

@bparees anything else on this?

bparees · 2016-05-24T16:05:33Z

nope, lgtm.

smarterclayton · 2016-05-26T02:52:19Z

[merge]

openshift-bot · 2016-05-26T02:55:19Z

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4099/) (Image: devenv-rhel7_4280)

openshift-bot · 2016-05-26T02:55:19Z

Evaluated for origin merge up to 1b10493

smarterclayton mentioned this pull request May 18, 2016

S2I needs to selectively log to stderr instead of glog openshift/source-to-image#500

Merged

smarterclayton force-pushed the fix_build_logging_2 branch from 23e7eb8 to 52b73a4 Compare May 18, 2016 15:55

bparees reviewed May 18, 2016
View reviewed changes

smarterclayton force-pushed the fix_build_logging_2 branch from 52b73a4 to 4b2104d Compare May 22, 2016 04:01

bparees reviewed May 22, 2016
View reviewed changes

smarterclayton force-pushed the fix_build_logging_2 branch from 4b2104d to 1b10493 Compare May 23, 2016 17:58

Update glogging to always set level, and to respect glog.level

1b10493

openshift-bot merged commit f80dcf3 into openshift:master May 26, 2016

gabemontero mentioned this pull request May 26, 2016

consistent build extended test failure #8903

Closed

csrwng mentioned this pull request Jun 10, 2016

build: loglevel=2 and loglevel=1 messages not getting logged (WAS: cluster up: builds do not get loglevel=2 by default) #9247

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update glogging to always set level, and to respect glog.level #8924

Update glogging to always set level, and to respect glog.level #8924

smarterclayton commented May 18, 2016

smarterclayton commented May 18, 2016 •

edited

Loading

smarterclayton commented May 18, 2016

smarterclayton commented May 18, 2016

gabemontero commented May 18, 2016

smarterclayton commented May 18, 2016

bparees May 18, 2016

smarterclayton May 22, 2016

bparees May 22, 2016

smarterclayton May 22, 2016 via email

bparees May 22, 2016

smarterclayton May 22, 2016

smarterclayton commented May 23, 2016

openshift-bot commented May 23, 2016

openshift-bot commented May 23, 2016

smarterclayton commented May 23, 2016

smarterclayton commented May 23, 2016

smarterclayton commented May 23, 2016

smarterclayton commented May 23, 2016

openshift-bot commented May 23, 2016

openshift-bot commented May 23, 2016

0xmichalis commented May 24, 2016

smarterclayton commented May 24, 2016

bparees commented May 24, 2016

smarterclayton commented May 26, 2016

openshift-bot commented May 26, 2016 •

edited

Loading

openshift-bot commented May 26, 2016

Update glogging to always set level, and to respect glog.level #8924

Update glogging to always set level, and to respect glog.level #8924

Conversation

smarterclayton commented May 18, 2016

smarterclayton commented May 18, 2016 • edited Loading

smarterclayton commented May 18, 2016

smarterclayton commented May 18, 2016

gabemontero commented May 18, 2016

smarterclayton commented May 18, 2016

bparees May 18, 2016

Choose a reason for hiding this comment

smarterclayton May 22, 2016

Choose a reason for hiding this comment

bparees May 22, 2016

Choose a reason for hiding this comment

smarterclayton May 22, 2016 via email

Choose a reason for hiding this comment

bparees May 22, 2016

Choose a reason for hiding this comment

smarterclayton May 22, 2016

Choose a reason for hiding this comment

smarterclayton commented May 23, 2016

openshift-bot commented May 23, 2016

openshift-bot commented May 23, 2016

smarterclayton commented May 23, 2016

smarterclayton commented May 23, 2016

smarterclayton commented May 23, 2016

smarterclayton commented May 23, 2016

openshift-bot commented May 23, 2016

openshift-bot commented May 23, 2016

0xmichalis commented May 24, 2016

smarterclayton commented May 24, 2016

bparees commented May 24, 2016

smarterclayton commented May 26, 2016

openshift-bot commented May 26, 2016 • edited Loading

openshift-bot commented May 26, 2016

smarterclayton commented May 18, 2016 •

edited

Loading

openshift-bot commented May 26, 2016 •

edited

Loading