openshift/kubernetes: stop modifying machine-os-content #49156
Conversation
That image isn't actually used in the cluster. We already have code in these same files to update the real image that gets used (`rhel-coreos`), so let's just drop these references. See also openshift/kubernetes#1805 (comment) and following. See also https://issues.redhat.com/browse/MCO-392.
|
[REHEARSALNOTIFIER]
A total of 118 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-openshift-kubernetes-release-4.16-e2e-azure pull-ci-openshift-kubernetes-release-4.16-e2e-azure-ovn-upgrade pull-ci-openshift-kubernetes-release-4.16-e2e-gcp pull-ci-openshift-kubernetes-release-4.16-e2e-gcp-ovn-upgrade pull-ci-openshift-kubernetes-release-4.16-e2e-metal-ipipull-ci-openshift-kubernetes-release-4.16-e2e-vsphere |
|
/lgtm |
|
@sdodson: job(s): pull-ci-openshift-kubernetes-release-4.16-e2e-metal-ipipull-ci-openshift-kubernetes-release-4.16-e2e-vsphere either don't exist or were not found to be affected, and cannot be rehearsed |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlebon, sdodson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/pj-rehearse pull-ci-openshift-kubernetes-release-4.16-e2e-metal-ipi pull-ci-openshift-kubernetes-release-4.16-e2e-vsphere |
|
/pj-rehearse pull-ci-openshift-kubernetes-release-4.16-e2e-gcp-ovn-upgrade pull-ci-openshift-kubernetes-release-4.16-e2e-azure pull-ci-openshift-kubernetes-release-4.16-e2e-azure-ovn-upgrade One more try on those which either failed to even run or those that failed in testing. I don't think there's any concern here. |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
See openshift/kubernetes#1805. What we're removing here is what will allow those references to get removed. |
|
IOW, the jobs we're removing here are what's referencing the code you linked to. So it needs to go in first. That'll fix CI on openshift/kubernetes#1805 to then allow that to go in (see openshift/kubernetes#1805 (comment)). |
|
@soltysh any way we could test for whatever problems the kube rebase ran into last time as soon as we land all of the changes? It'd be nice to confirm whatever problems we ran into aren't happening now in case we decide to revert. |
|
This was discussed with @jlebon and @sdodson yesterday, we're going to merge these PRs one after the other (openshift/kubernetes#1805) to fix the situation. /hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/pj-rehearse ack |
openshift-ci-robot
added
the
rehearsals-ack
|
@jlebon: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This was previously enabled (openshift#1048, openshift#1374) and then disabled again (openshift#1084, openshift#1393). The last time we tried it, the issue was that there were some references remaining in openshift/kubernetes and openshift/release. Those have been cleaned up now: openshift/release#49156 openshift/kubernetes#1805 So... third time's the charm!
This was previously enabled (openshift#1048, openshift#1374) and then disabled again (openshift#1084, openshift#1393). The last time we tried it, the issue was that there were some references remaining in openshift/kubernetes and openshift/release. Those have been cleaned up now: openshift/release#49156 openshift/kubernetes#1805 So... third time's the charm!
) That image isn't actually used in the cluster. We already have code in these same files to update the real image that gets used (`rhel-coreos`), so let's just drop these references. See also openshift/kubernetes#1805 (comment) and following. See also https://issues.redhat.com/browse/MCO-392.
That image isn't actually used in the cluster. We already have code in these same files to update the real image that gets used (
rhel-coreos), so let's just drop these references.See also openshift/kubernetes#1805 (comment) and following.
See also https://issues.redhat.com/browse/MCO-392.