-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
platform/v1alpha1: Update the cluster profile annotations #1282
platform/v1alpha1: Update the cluster profile annotations #1282
Conversation
Hello @timflannagan! Some important instructions when contributing to openshift/api: For merging purposes, this repository follows the no-Feature-Freeze process which means that in addition to the standard
OR
Who should apply these qe/docs/px labels?
|
/assign @bparees |
e944538
to
74ba920
Compare
857aeda
to
d46b703
Compare
Signed-off-by: timflannagan <timflannagan@gmail.com>
I wasn't able to easily run any of the Makefile update/verify related targets locally so I had to manually inspect the prowjob failures to determine what changes are needed. The last force push should (hopefully ™️) fix that failing verification check. |
@bparees Do you have time to take another look at this? We're just removing the hacks that are in-tree for the o/platform-operators repository: https://github.com/openshift/platform-operators/blob/main/Makefile#L80-L83, and it would be nice to get this in before end of sprint 225 to avoid needing to create a bug. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We're doing the TE slides so manually adding the px-approved label. See https://coreos.slack.com/archives/C030W4V9BHN/p1661875975344669 for more information. /label px-approved |
/label docs-approved |
Holding for QE approval. This is a no-op while we work towards removing the hacks in the o/platform-operators repository that already contain these cluster profile annotations. /assign jianzhangbjz |
/label qe-approved |
@timflannagan: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Update the PlatformOperator CRD and add the required self-managed-high-availability cluster profile.
Signed-off-by: timflannagan timflannagan@gmail.com