Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platform/v1alpha1: Update the cluster profile annotations #1282

Conversation

timflannagan
Copy link
Contributor

Update the PlatformOperator CRD and add the required self-managed-high-availability cluster profile.

Signed-off-by: timflannagan timflannagan@gmail.com

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 2, 2022

Hello @timflannagan! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

For merging purposes, this repository follows the no-Feature-Freeze process which means that in addition to the standard lgtm and approved labels this repository requires either:

bugzilla/valid-bug - applied if your PR references a valid bugzilla bug

OR

qe-approved, docs-approved, and px-approved - these labels can be applied by anyone in the openshift org via the /label <labelname> command.

Who should apply these qe/docs/px labels?

  • For a no-Feature-Freeze team who is merging a feature before code freeze, they need to get those labels applied to their api repo PR by the appropriate teams (i.e. qe, docs, px)
  • For a Feature Freeze (traditional) team who is merging a feature before FF, they can self-apply the labels (via /label commands), they are basically irrelevant for those teams
  • For a Feature Freeze team who is merging a feature after FF, the PR should be rejected barring an exception

@jianzhangbjz
Copy link

/assign @bparees

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 8, 2022
@timflannagan timflannagan force-pushed the platformoperator/add-self-managed-high-availability branch from e944538 to 74ba920 Compare September 15, 2022 16:20
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 15, 2022
@timflannagan timflannagan changed the title platform/v1alpha1: Add the self managed HA cluster profile platform/v1alpha1: Update the cluster profile annotations for the PlatformOperators CRD Sep 15, 2022
@timflannagan timflannagan changed the title platform/v1alpha1: Update the cluster profile annotations for the PlatformOperators CRD platform/v1alpha1: Update the cluster profile annotations Sep 15, 2022
@timflannagan timflannagan force-pushed the platformoperator/add-self-managed-high-availability branch 2 times, most recently from 857aeda to d46b703 Compare September 15, 2022 17:20
Signed-off-by: timflannagan <timflannagan@gmail.com>
@timflannagan
Copy link
Contributor Author

I wasn't able to easily run any of the Makefile update/verify related targets locally so I had to manually inspect the prowjob failures to determine what changes are needed. The last force push should (hopefully ™️) fix that failing verification check.

@timflannagan
Copy link
Contributor Author

timflannagan commented Sep 19, 2022

@bparees Do you have time to take another look at this? We're just removing the hacks that are in-tree for the o/platform-operators repository: https://github.com/openshift/platform-operators/blob/main/Makefile#L80-L83, and it would be nice to get this in before end of sprint 225 to avoid needing to create a bug.

@bparees
Copy link
Contributor

bparees commented Sep 19, 2022

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2022
@timflannagan
Copy link
Contributor Author

We're doing the TE slides so manually adding the px-approved label. See https://coreos.slack.com/archives/C030W4V9BHN/p1661875975344669 for more information.

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Sep 19, 2022
@adellape
Copy link

/label docs-approved

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Sep 19, 2022
@timflannagan
Copy link
Contributor Author

Holding for QE approval. This is a no-op while we work towards removing the hacks in the o/platform-operators repository that already contain these cluster profile annotations.

/assign jianzhangbjz
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 19, 2022
@jianzhangbjz
Copy link

/label qe-approved
/unhold

@openshift-ci openshift-ci bot added qe-approved Signifies that QE has signed off on this PR and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 22, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2022

@timflannagan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 3bb5fd5 into openshift:master Sep 22, 2022
@timflannagan timflannagan deleted the platformoperator/add-self-managed-high-availability branch September 22, 2022 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants